Skip to content

Conversation

jeremypw
Copy link
Collaborator

Fixes #1523

@jeremypw jeremypw marked this pull request as ready for review May 26, 2025 11:31
Comment on lines +1379 to +1381
private void change_terminal_path (string path) {
terminal.change_location (path);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this probably doesn't need to be a separate function. This seems like it just obfuscates the code. terminal.change_location is already pretty obvious in what it does

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

@jeremypw
Copy link
Collaborator Author

I seem to have incorporated a fix for this issue into a later PR #1574 so I think I'll close this one in favor of that.

@jeremypw jeremypw closed this May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terminal Pane does not follow current active project path on startup or when reopened

2 participants