Partition DynamicConsumerSupervisor to improve startup and shutdown times #3183
+40
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3183 +/- ##
==========================================
- Coverage 77.00% 76.85% -0.16%
==========================================
Files 175 175
Lines 9260 9264 +4
Branches 295 296 +1
==========================================
- Hits 7131 7120 -11
- Misses 2127 2142 +15
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a supervisor layer where a
PartitionSupervisornow carries theDynamicConsumerSupervisor.name(stack_id)name and it starts a number ofDynamicConsumerSupervisorprocesses to shard load between them. This change is transparent for the rest of the code that usesDynamicConsumerSupervisor's public API.I've done some measurements by repeatedly starting Electric, waiting for it to start all consumer processes, then terminating it with the
SIGTERMsignal. I have done 5 attempts for the current implementation inmainand for this PR, measure both the startup and shutdown time.The 1st attempt can be considered an outlier since timings have become consistent afterwards.
When a PartitionSupervisor is used, all processes shut down within 2-3 seconds and the rest of the shutdown time is dominated by the shape status table backup.