-
Notifications
You must be signed in to change notification settings - Fork 100
re-enable CGO and buildmode pie #5715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This pull request does not have a backport label. Could you fix it @pchila? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, checked the produced artifacts and the GLIBC dependencies are compatible with our OS matrix support
fleet-server-9.3.0-linux-x86_64/fleet-server
GLIBC_2.3.2
GLIBC_2.2.5
GLIBC_2.2.5
fleet-server-9.3.0-linux-arm64/fleet-server
GLIBC_2.17
GLIBC_2.17
@Mergifyio backport 8.19 9.0 9.1 9.2 |
✅ Backports have been created
|
(cherry picked from commit 693bd7b)
(cherry picked from commit 693bd7b) # Conflicts: # magefile.go
(cherry picked from commit 693bd7b)
(cherry picked from commit 693bd7b)
(cherry picked from commit 693bd7b)
(cherry picked from commit 693bd7b)
What is the problem this PR solves?
Re-enable CGO and buildmode pie to restore fleet-server metrics on darwin
How does this PR solve the problem?
How to test this PR locally
Design Checklist
Checklist
./changelog/fragments
using the changelog toolRelated issues