Skip to content

Conversation

pchila
Copy link
Member

@pchila pchila commented Oct 16, 2025

What is the problem this PR solves?

Re-enable CGO and buildmode pie to restore fleet-server metrics on darwin

How does this PR solve the problem?

How to test this PR locally

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

@pchila pchila self-assigned this Oct 16, 2025
@pchila pchila requested a review from a team as a code owner October 16, 2025 18:28
@prodsecmachine
Copy link

prodsecmachine commented Oct 16, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Licenses 0 0 0 0 0 issues
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@pchila pchila added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Oct 16, 2025
Copy link
Contributor

mergify bot commented Oct 16, 2025

This pull request does not have a backport label. Could you fix it @pchila? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

Copy link
Member

@rubenruizdegauna rubenruizdegauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked the produced artifacts and the GLIBC dependencies are compatible with our OS matrix support

fleet-server-9.3.0-linux-x86_64/fleet-server
GLIBC_2.3.2
GLIBC_2.2.5
GLIBC_2.2.5

fleet-server-9.3.0-linux-arm64/fleet-server
GLIBC_2.17
GLIBC_2.17

@pchila pchila added the backport-active-all Automated backport with mergify to all the active branches label Oct 17, 2025
@pchila pchila merged commit 693bd7b into elastic:main Oct 17, 2025
14 checks passed
Copy link
Contributor

@Mergifyio backport 8.19 9.0 9.1 9.2

Copy link
Contributor

mergify bot commented Oct 17, 2025

backport 8.19 9.0 9.1 9.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 17, 2025
mergify bot pushed a commit that referenced this pull request Oct 17, 2025
(cherry picked from commit 693bd7b)

# Conflicts:
#	magefile.go
mergify bot pushed a commit that referenced this pull request Oct 17, 2025
mergify bot pushed a commit that referenced this pull request Oct 17, 2025
pchila added a commit that referenced this pull request Oct 20, 2025
pchila added a commit that referenced this pull request Oct 20, 2025
pchila added a commit that referenced this pull request Oct 20, 2025
(cherry picked from commit 693bd7b)

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
pchila added a commit that referenced this pull request Oct 20, 2025
(cherry picked from commit 693bd7b)

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
pchila added a commit that referenced this pull request Oct 20, 2025
(cherry picked from commit 693bd7b)

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-all Automated backport with mergify to all the active branches Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants