-
Notifications
You must be signed in to change notification settings - Fork 450
[RFC 0052] Stage 2: Update additional GenAI fields #2532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Documentation changes preview: https://docs-v3-preview.elastic.dev/elastic/ecs/pull/2532/reference/ |
🔍 Preview links for changed docs |
8ece5e6
to
9b177e4
Compare
1b04b05
to
22cdf78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as stage 2 is a final stage, please update all examples and generate all fields
2b0a2e2
to
8a89add
Compare
@flash1293 thanks a lot for explaining the tradeoffs. For the fields where it would be more useful to keep the associations and have more cases for searching, I changed the field type to |
Thanks @susan-shu-c - side note, do we have cases of existing nested and flattened ECS fields already? |
Hi @flash1293 there are a few: Flattened: Nested: |
Thanks for the comments all. I've updated the following:
However, when I try to run Also getting a failure in tests
OTel reference: https://opentelemetry.io/docs/specs/semconv/registry/attributes/gen-ai/#gen-ai-output-messages |
Migrating a slack thought to the issue for posterity. Here are a couple things we should consider before pushing this forward.
|
@susan-shu-c you error about not finding As an idea we can just always work against main in otel. There are no things deleted anymore, everything is deprecated. |
hi, for now, I have marked the ![]() |
1. What does this PR do?
2. Which ECS fields are affected/introduced?
Changes based on OTel:
3. Why is this change necessary?
4. Have you added/updated documentation?
YES / NO / N/A
5. Have you built ECS and committed any newly generated files?
YES / NO
6. Have you run the ECS validation tests locally?
YES / NO
7. Anything else for the reviewers?
Looking for feedback
[Edit: see comment]
For the fields where it would be more useful to keep the associations and have more cases for searching, I changed the field type to nested, and for those that don't need the associations and probably don't need nested searching, I changed them to flattened.
For most of the fields, they are lists of .json objects, or .json objects. For fields whose content could be very long (input.messages
,output.messages
), I have proposed that they are theflattened
type due to costs.via docs for
nested
type:Though as I am not a subject matter expert on the field types and efficiency, looking for additional feedback or comments.
Commit Message