Improve Quick Search Dialog UI #3328

deepika-u · 2025-09-24T14:59:04Z

This pr basically addresses the below issues

1. When 1 or more search results exist, by default no entry is shown till user selects but now 1st entry is showed in preview section.
2. After a search, when search pattern is cleared, the preview remains which is no more valid. Now the preview is cleared.
3. Move Refresh button to the search pattern line towards the right end.

When there are 1 or more multiple search results, by default nothing is selected and shown in preview till user selects an entry. Now the 1st entry is shown by default.

Multiple search results
Before :

After :

1 Search result
Before :

After :

Now when the search pattern is cleared but preview section still showing up stale entries which are no more valid. Even the ruler section for the preview needs to be cleared.

Before :

After :

Move Refresh button to the search pattern line towards the extreme right end. Functionality of refresh being untouched.
Before :

After :

Please do let me know if you have any suggestions in the same context.

github-actions · 2025-09-24T15:46:38Z

Test Results

3 018 files ±0 3 018 suites ±0 2h 21m 33s ⏱️ - 12m 43s
8 226 tests ±0 7 977 ✅ +1 249 💤 ±0 0 ❌ - 1
23 598 runs ±0 22 804 ✅ +1 794 💤 ±0 0 ❌ - 1

Results for commit 812b598. ± Comparison against base commit 080a1c7.

♻️ This comment has been updated with latest results.

BeckerWdf · 2025-09-25T08:00:45Z

Nice work. Always good so see such small but very helpfull improvement.

If am unsure about this:

Refresh button is a simple button. Now it is shown like an icon as in any other Git Repo view or Search view.

Why do you think that the icon is better then text button? Couldn't we also keep the button but add the icon to the button?

BeckerWdf · 2025-09-25T08:06:20Z

Nice work. Always good so see such small but very helpfull improvement.

If am unsure about this:

Refresh button is a simple button. Now it is shown like an icon as in any other Git Repo view or Search view.

Why do you think that the icon is better then text button? Couldn't we also keep the button but add the icon to the button?

In addition: For refresh I also see this icon in the IDE:

and this:

When to use which one?

BeckerWdf · 2025-09-25T08:11:45Z

I have the feeling that the "icon" only would be correct if it's in a toolbar. But here we have a dialog that does not have a toolbar and for me it feels more correct to have a button.

deepika-u · 2025-09-25T09:46:19Z

Nice work. Always good so see such small but very helpful improvement.

Would love to do. Thanks. Anything which basically improves the user experience - i am happy to contribute there :)

If am unsure about this:

Refresh button is a simple button. Now it is shown like an icon as in any other Git Repo view or Search view.

Why do you think that the icon is better then text button? Couldn't we also keep the button but add the icon to the button?

Let me check on it and update you.

deepika-u · 2025-09-25T10:00:36Z

In addition: For refresh I also see this icon in the IDE:

image 1: used specifically for file refresh (e.g., synchronizing a file with the filesystem).

and this:

image 2: the more generic refresh icon, used in contexts like search results, project refresh, or view updates.

When to use which one?

Since in this dialog the action is to refresh the search results, I chose the generic refresh icon.

BeckerWdf · 2025-09-25T11:00:32Z

Since in this dialog the action is to refresh the search results, I chose the generic refresh icon.

Yes. I agree.

deepika-u · 2025-09-26T05:02:46Z

@BeckerWdf
How does this look?

Please do share me an opinion on this? Alignment and spacing needs to be set, nothing finalized, just tried.

BeckerWdf · 2025-09-26T14:02:29Z

I just had a chat with our UX-Expert on this topic.
She recommends not to use the "refresh" icon for that. See says that the "Referesh" button is totally fine as it is.
But one additional thing. Maybe we can move the "Refresh" button un into the same row as the text input fields. So in the same location has you have shown it here:

But keeping it as a button.

Just out of curiosity: Why is this button needed at all? I have had the need to press it. Can you explain that to me?

deepika-u · 2025-10-10T11:01:18Z

@BeckerWdf
I have checked and updated as below. Sorry for the delayed response as i got occupied with another issue.

Thanks for checking with UI experts.

Regarding why the button is needed:

The search results don’t always auto-update if resources change externally (e.g. file changes from Git or another tool).
Having an explicit refresh gives users a safe way to make sure results are up to date without closing/reopening the dialog.
This also matches the pattern in other Eclipse views, where a manual refresh coexists with auto-updates.

So while it may not be used often, it provides an escape hatch when results are stale. Hope i have answered all your questions. Thanks.

BeckerWdf · 2025-10-10T11:17:45Z

@BeckerWdf I have checked and updated as below. Sorry for the delayed response as i got occupied with another issue.

No worries. This happens to all of us.

Thanks for checking with UI experts.

Sure. I am always happy to help in the UX area there it's possible

Regarding why the button is needed:

The search results don’t always auto-update if resources change externally (e.g. file changes from Git or another tool).

Having an explicit refresh gives users a safe way to make sure results are up to date without closing/reopening the dialog.

This also matches the pattern in other Eclipse views, where a manual refresh coexists with auto-updates.

So while it may not be used often, it provides an escape hatch when results are stale.

Understood. I expected something like this.

BeckerWdf · 2025-10-10T11:27:57Z

...eclipse.text.quicksearch/src/org/eclipse/text/quicksearch/internal/ui/QuickSearchDialog.java

 		searchIn.setToolTipText(Messages.QuickSearchDialog_InTooltip);
 		GridDataFactory.fillDefaults().grab(true, false).indent(5, 0).applyTo(searchIn);

+		// Refresh button next to pattern field towards extreme right


can't we use something like:

Button refreshButton = createButton(inputRow, REFRESH_BUTTON_ID, Messages.QuickSearchDialog_Refresh, false); GridDataFactory.swtDefaults().align(SWT.CENTER, SWT.CENTER).grab(false, false).applyTo(refreshButton); refreshButton.addListener(SWT.Selection, e -> refreshButtonPressed())

Button refreshButton = createButton(inputRow, REFRESH_BUTTON_ID, Messages.QuickSearchDialog_Refresh, false); GridDataFactory.swtDefaults().align(SWT.CENTER, SWT.CENTER).grab(false, false).applyTo(refreshButton); refreshButton.addListener(SWT.Selection, e -> refreshButtonPressed())

I just tried your suggestion as is and thinking this is more lesser lines of code(looks more appealing and readable for me too.). But when i tested i am seeing this small behavior change where alignment is lost.

In the image, 1st section corresponds to createButton() kind of creation of button.
2nd section as per the existing pr change.

But thanks for letting me know various ways of thinking to address the same issue. Hope i have answered all the concerns raised. If i have missed any please do let me know.

Thanks alot @BeckerWdf in advance.

- Auto-show first result in preview. - Clear preview when search is empty removing stale entries. - Move Refresh button to the search pattern line towards the right end.

deepika-u force-pushed the Quick_search_refresh branch from 58e4a5c to dbea632 Compare September 24, 2025 14:59

deepika-u force-pushed the Quick_search_refresh branch 3 times, most recently from a7d0451 to bbce42a Compare September 25, 2025 06:56

deepika-u force-pushed the Quick_search_refresh branch from bbce42a to c08610f Compare September 25, 2025 18:01

deepika-u changed the title ~~Fine tuning of Quick Search Dialog~~ Improve Quick Search Dialog UI Sep 26, 2025

deepika-u force-pushed the Quick_search_refresh branch 2 times, most recently from 9fbdf90 to d8a69d8 Compare October 10, 2025 10:59

BeckerWdf requested changes Oct 10, 2025

View reviewed changes

deepika-u force-pushed the Quick_search_refresh branch 2 times, most recently from 532dc80 to 7d36d8d Compare October 13, 2025 12:06

This commit enhances Quick Search dialog with

812b598

- Auto-show first result in preview. - Clear preview when search is empty removing stale entries. - Move Refresh button to the search pattern line towards the right end.

deepika-u force-pushed the Quick_search_refresh branch from 7d36d8d to 812b598 Compare October 13, 2025 12:06

deepika-u requested a review from BeckerWdf October 15, 2025 06:58

Improve Quick Search Dialog UI #3328

Are you sure you want to change the base?

Improve Quick Search Dialog UI #3328

Conversation

deepika-u commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

BeckerWdf commented Sep 25, 2025

Uh oh!

BeckerWdf commented Sep 25, 2025

Uh oh!

BeckerWdf commented Sep 25, 2025

Uh oh!

deepika-u commented Sep 25, 2025

Uh oh!

deepika-u commented Sep 25, 2025

Uh oh!

BeckerWdf commented Sep 25, 2025

Uh oh!

deepika-u commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BeckerWdf commented Sep 26, 2025

Uh oh!

deepika-u commented Oct 10, 2025

Uh oh!

BeckerWdf commented Oct 10, 2025

Uh oh!

BeckerWdf Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

deepika-u Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

deepika-u commented Sep 24, 2025 •

edited

Loading

github-actions bot commented Sep 24, 2025 •

edited

Loading

deepika-u commented Sep 26, 2025 •

edited

Loading