Added PHP 8.5 to CI. #177

AlexSkrypnyk · 2025-09-11T10:09:04Z

Package "php ^8.5" found in version "8.5.0" (version provided by config.platform).
php 8.5.0 Package overridden via config.platform, actual: 8.3.22
├──czproject/git-php v4.5.0 (requires php 8.0 - 8.4)
│  └──drevops/git-artifact dev-main (requires czproject/git-php ^4.3)
├──ergebnis/composer-normalize 2.47.0 (requires php ~7.4.0 || ~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0)
│  └──drevops/git-artifact dev-main (requires (for development) ergebnis/composer-normalize ^2.43)
├──ergebnis/json 1.4.0 (requires php ~7.4.0 || ~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0)
│  ├──ergebnis/composer-normalize 2.47.0 (requires ergebnis/json ^1.4.0)
│  │  └──drevops/git-artifact dev-main (requires (for development) ergebnis/composer-normalize ^2.43)
│  ├──ergebnis/json-normalizer 4.9.0 (requires ergebnis/json ^1.2.0)
│  │  └──ergebnis/composer-normalize 2.47.0 (requires ergebnis/json-normalizer ^4.9.0)
│  │     └──drevops/git-artifact dev-main (requires (for development) ergebnis/composer-normalize ^2.43)
│  └──ergebnis/json-schema-validator 4.4.0 (requires ergebnis/json ^1.2.0)
│     └──ergebnis/json-normalizer 4.9.0 (requires ergebnis/json-schema-validator ^4.2.0)
│        └──ergebnis/composer-normalize 2.47.0 (requires ergebnis/json-normalizer ^4.9.0)
│           └──drevops/git-artifact dev-main (requires (for development) ergebnis/composer-normalize ^2.43)
├──ergebnis/json-normalizer 4.9.0 (requires php ~7.4.0 || ~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0)
│  └──ergebnis/composer-normalize 2.47.0 (requires ergebnis/json-normalizer ^4.9.0)
│     └──drevops/git-artifact dev-main (requires (for development) ergebnis/composer-normalize ^2.43)
├──ergebnis/json-pointer 3.6.0 (requires php ~7.4.0 || ~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0)
│  ├──ergebnis/json-normalizer 4.9.0 (requires ergebnis/json-pointer ^3.4.0)
│  │  └──ergebnis/composer-normalize 2.47.0 (requires ergebnis/json-normalizer ^4.9.0)
│  │     └──drevops/git-artifact dev-main (requires (for development) ergebnis/composer-normalize ^2.43)
│  └──ergebnis/json-schema-validator 4.4.0 (requires ergebnis/json-pointer ^3.4.0)
│     └──ergebnis/json-normalizer 4.9.0 (requires ergebnis/json-schema-validator ^4.2.0)
│        └──ergebnis/composer-normalize 2.47.0 (requires ergebnis/json-normalizer ^4.9.0)
│           └──drevops/git-artifact dev-main (requires (for development) ergebnis/composer-normalize ^2.43)
├──ergebnis/json-printer 3.7.0 (requires php ~7.4.0 || ~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0)
│  ├──ergebnis/composer-normalize 2.47.0 (requires ergebnis/json-printer ^3.7.0)
│  │  └──drevops/git-artifact dev-main (requires (for development) ergebnis/composer-normalize ^2.43)
│  └──ergebnis/json-normalizer 4.9.0 (requires ergebnis/json-printer ^3.5.0)
│     └──ergebnis/composer-normalize 2.47.0 (requires ergebnis/json-normalizer ^4.9.0)
│        └──drevops/git-artifact dev-main (requires (for development) ergebnis/composer-normalize ^2.43)
├──ergebnis/json-schema-validator 4.4.0 (requires php ~7.4.0 || ~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0)
│  └──ergebnis/json-normalizer 4.9.0 (requires ergebnis/json-schema-validator ^4.2.0)
│     └──ergebnis/composer-normalize 2.47.0 (requires ergebnis/json-normalizer ^4.9.0)
│        └──drevops/git-artifact dev-main (requires (for development) ergebnis/composer-normalize ^2.43)
└──localheinz/diff 1.2.0 (requires php ~7.1.0 || ~7.2.0 || ~7.3.0 || ~7.4.0 || ~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0)
   └──ergebnis/composer-normalize 2.47.0 (requires localheinz/diff ^1.2.0)
      └──drevops/git-artifact dev-main (requires (for development) ergebnis/composer-normalize ^2.43)

coderabbitai · 2025-09-11T10:09:12Z

📝 Walkthrough

Walkthrough

Adds PHP 8.5 to the GitHub Actions PHP test matrix and removes PHP CodeSniffer-related dev dependencies, plugin permission, and related lint scripts from composer.json; no other logic or exported entities were changed.

Changes

Cohort / File(s)	Summary
CI Workflow `.github/workflows/test-php.yml`	Extended `php-versions` matrix from `['8.2','8.3','8.4']` to `['8.2','8.3','8.4','8.5']`; no other workflow steps or logic modified.
Composer / Lint config `composer.json`	Removed dev dependencies `dealerdirect/phpcodesniffer-composer-installer` and `drupal/coder`; removed `dealerdirect/phpcodesniffer-composer-installer` from `config.allow-plugins`; removed `phpcs` from `scripts.lint` and `phpcbf` from `scripts.lint-fix` (retained `rector --clear-cache`).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title “Added PHP 8.5 to CI.” succinctly and accurately captures the main change of extending the CI configuration to include PHP 8.5, is clear and specific without extraneous details, and will be immediately understandable to team members reviewing the project history.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feature/ci-php8.5

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6e4fc2d and 552a144.

📒 Files selected for processing (1)

composer.json (1 hunks)

🧰 Additional context used

🪛 GitHub Actions: Test PHP

composer.json

[error] 1-1: dealerdirect/phpcodesniffer-composer-installer contains a Composer plugin which is blocked by your allow-plugins config. You may add it to the list if you consider it safe.

🔇 Additional comments (3)

composer.json (3)

63-65: Lint-fix script adjustment aligns with removal of phpcs/phpcbf.

Keeping only rector in lint-fix is consistent and reduces tool churn. LGTM.

17-26: Runtime deps look compatible with PHP 8.5; no change requested.

Constraint php >= 8.2 with Symfony 7/Monolog 3 is fine for adding 8.5 to CI.

27-33: CI matrix doesn’t include PHP 8.5—no conditional skips or PHP 8.5-specific installs are needed.

Likely an incorrect or invalid review comment.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

AlexSkrypnyk · 2025-09-30T13:25:54Z

@coderabbitai
Can you update this pr with a removal of php8.5 incompatible packages, but only if they are in require-dev and not needed for testing . Remove in gha

coderabbitai · 2025-09-30T13:30:55Z

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Read composer.json to see require-dev dependencies
cat composer.json | jq '{
  "require-dev": ."require-dev"
}'

Length of output: 288

🏁 Script executed:

#!/bin/bash
# Read the test-php.yml workflow to understand the current setup
cat .github/workflows/test-php.yml

Length of output: 11046

🏁 Script executed:

#!/bin/bash
# Check if there's a phpunit.xml or phpunit configuration to understand testing needs
fd -t f "phpunit" -e xml -e dist

Length of output: 11

🏁 Script executed:

#!/bin/bash
# Check composer.json scripts to understand what lint and test-coverage do
cat composer.json | jq '{
  "scripts": .scripts
}'

Length of output: 427

🏁 Script executed:

#!/bin/bash
# Read phpunit.xml to understand testing setup
cat phpunit.xml

Length of output: 1665

🌐 Web query:

drupal/coder PHP 8.5 compatibility

💡 Result:

Short answer: Yes — recent drupal/coder releases are compatible with PHP 8.5. The current stable 8.3.x release series (e.g. 8.3.30) declares "php: >=7.2" in its composer metadata (no upper bound), so Composer will allow PHP 8.5. [1][2]

Notes:

Coder depends on PHP_CodeSniffer and other packages; if those dependencies are updated to require a newer PHP range, Composer will resolve appropriately. Check your composer.lock / run composer update to verify dependency resolution on your environment. [1][2]

Sources:

Drupal project page / releases (coder 8.3.30, May 25, 2025). [1]
Packagist drupal/coder (requires php >=7.2). [2]

🌐 Web query:

phpstan PHP 8.5 compatibility

💡 Result:

Short answer: Not yet officially — as of Sep 30, 2025 PHP 8.5 is still a development/RC branch (GA scheduled Nov 20, 2025) and PHPStan has not published a “ready for PHP 8.5” announcement. PHPStan historically adds support after PHP stubs / nikic/php-parser support land, and the project has said it would add new‑minor PHP support in followup releases (e.g. PHP 8.4 was targeted after 2.0). [1][2][3]

What to do now

If you want to test 8.5 compatibility with PHPStan today, run PHPStan on your code with phpVersion set to the target ID (e.g. 80500) — this lets PHPStan emulate a newer PHP version where supported — but expect incomplete coverage until PHPStan (stubs/php-parser) explicitly add full 8.5 support. [3][1]

Sources

PHP 8.5 release schedule (GA Nov 20, 2025). [1]
PHPStan 2.0 post (plans to add newer PHP support after release; mentioned 8.4). [2]
PHPStan notes about phpVersion / analyzing different PHP versions. [3]

🌐 Web query:

rector PHP 8.5 compatibility

💡 Result:

Short answer: Yes — Rector has PHP 8.5-specific rules and sets. Use a recent Rector 2.x release (which added many Php85 rules) and enable the PHP sets in your rector config (or set the project PHP version in composer.json so Rector picks it up). [1][2]

How to use:

Install/upgrade to the latest Rector 2.x release.
In rector.php use withPhpSets() or the new config helpers (Rector will pick PHP version from composer.json) or explicitly enable PHP sets. Example: ->withPhpSets(php85: true) or set composer.json "platform": {"php":"8.5"} so Rector loads the correct upgrade rules. See docs for withPhpSets and the 2.x release notes for Php85 rules. [2][3]

Sources:

Rector release notes showing Php85 rules (release changelog). [1]
Rector docs: withPhpSets / prepared sets (how to enable PHP-version sets). [2]

References:
[1] Rector releases — PHP 8.5 rules added. (Rector changelog/releases).
[2] Rector documentation — Set lists / withPhpSets usage.

🌐 Web query:

ergebnis/composer-normalize PHP 8.5 compatibility

💡 Result:

Yes — current ergebnis/composer-normalize releases declare support for PHP 8.5 (requires: ~7.4.0 || ~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0 || ~8.5.0). [1]

Source: Packagist package page for ergebnis/composer-normalize. [1]

Task: Conditionally remove PHP 8.5 incompatible packages in GitHub Actions

Based on the web search results:

phpstan is not yet officially compatible with PHP 8.5 (PHP 8.5 GA is Nov 20, 2025)
All other require-dev packages are compatible

Plan:

Modify the "Install dependencies" step to conditionally install packages based on PHP version
Skip linting and normalization steps for PHP 8.5 (since phpstan is incompatible and not needed for testing)
For PHP 8.5: install without dev dependencies, then manually install only phpunit for testing

⏳ Preparing changes...

coderabbitai · 2025-09-30T13:31:19Z

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Read composer.json to see require-dev dependencies
cat composer.json

Length of output: 2127

🏁 Script executed:

#!/bin/bash
# Find test files to understand what's needed for testing
fd -e php test

Length of output: 300

🏁 Script executed:

#!/bin/bash
# Check the test workflow to see what's actually used in CI
cat .github/workflows/test-php.yml

Length of output: 11046

🏁 Script executed:

#!/bin/bash
# Look for phpunit configuration to understand test setup
fd -e xml phpunit
cat phpunit.xml.dist 2>/dev/null || cat phpunit.xml 2>/dev/null || echo "No phpunit config found"

Length of output: 1677

🌐 Web query:

drupal/coder PHP 8.5 compatibility

💡 Result:

Short answer: drupal/coder itself does not forbid PHP 8.5 (composer indicates "php: >=7.2"), so there is no hard PHP upper-bound preventing installation on PHP 8.5 — but it is not explicitly marked as "PHP 8.5 tested" in the project notes. Test/confirm in your environment because compatibility also depends on coder's dependencies (phpcs, slevomat, symfony/yaml, etc.) and Drupal core versions you use. [1][2]

What to check next (quick):

drupal/coder current composer metadata (shows php: >=7.2 and recent releases). [1]
Run your project's composer require / composer update on PHP 8.5 and run phpcs/phpcbf tests to catch issues.
If you hit problems, open an issue on the coder project or check Drupal core issues for PHP 8.4/8.5 work (many core projects have separate PHP 8.4/8.5 compatibility threads). [2][3]

Sources:

drupal/coder (Packagist — package details, requirements). [1]
Installing Coder — Drupal documentation (installation/testing guidance, last updated May 2025). [2]
Drupal PHP 8.x compatibility meta/issue threads (example: PHP 8.4 work that shows ecosystem effort for newer PHP versions). [3]

🌐 Web query:

rector/rector PHP 8.5 support

💡 Result:

Short answer: Yes — Rector has added PHP 8.5-specific rules. Recent Rector releases (2.x) include many Php85 rules (e.g. renames, deprecated-arg removals, constant/attribute updates). Use the latest Rector 2.x and enable the PHP 8.5 set. [1][2]

Sources:

Rector releases (PHP 8.5 entries in changelog). [1]
Release notes listing many Php85 rules (example: 2.1.5). [2]
PHP 8.5 release schedule (for context). [3]

🌐 Web query:

phpstan/phpstan PHP 8.5 compatibility

💡 Result:

Short answer: yes—PHPStan can analyze code for PHP 8.5, but you should use a recent PHPStan release that includes PHP 8.5 support (or configure phpVersion manually) and run it on a PHP build that matches your target when needed.

Details and sources:

PHPStan’s code contains a PhpVersion abstraction and it’s explicitly aware of different PHP releases; you can set the target PHP version via parameters (phpVersion) to make analyses behave as if running on a different PHP release. [1][2]
PHPStan’s changelogs and docs show it tracks new PHP features (e.g., PHP 8.x additions) and adds support in recent releases; upgrade to the latest stable PHPStan (or the bleeding-edge preview) to get newest version-aware checks. [3][4]
PHP 8.5 is the active development branch with GA planned for November 20, 2025; if you target pre‑GA builds (RC/beta), make sure to run PHPStan on a release that mentions 8.5 support or set phpVersion to the appropriate numeric value while using the latest PHPStan. [5]

If you want, tell me which PHPStan version you’re currently using (composer show phpstan/phpstan) and I’ll check whether that specific version supports PHP 8.5 or which PHPStan release to upgrade to.

Sources:
[1] PHPStan PhpVersion source/API.
[2] PHPStan docs — setting phpVersion / version-awareness.
[3] PHPStan release notes / changelogs.
[4] PHPStan discussion: version compatibility and checks.
[5] PHP 8.5 release schedule (php.watch).

🌐 Web query:

bamarni/composer-bin-plugin PHP 8.5

💡 Result:

Yes — bamarni/composer-bin-plugin's composer.json requires "php": "^7.2.5 || ^8.0", so it accepts PHP 8.x (including 8.5). [1]

Source:

composer.json in the repo (require: "php": "^7.2.5 || ^8.0"). [1]

🌐 Web query:

ergebnis/composer-normalize PHP 8.5 compatibility

💡 Result:

Short answer: Yes — ergebnis/composer-normalize declares compatibility with PHP 8.5. See the package requirements on Packagist and the project README. [1][2]

Sources:

Packagist package page showing "php: ~7.4.0 || ~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0 || ~8.5.0". [1]
GitHub repository (README / PHP version support policy). [2]

🌐 Web query:

dealerdirect/phpcodesniffer-composer-installer PHP 8.5

💡 Result:

Short answer: Yes — dealerdirect/phpcodesniffer-composer-installer supports PHP 8.x (so it will work on PHP 8.5). See the project's README and Packagist which state compatibility with PHP 8.x and Packagist's current package requirements (php: >=5.4). [1][2]

Notes:

Use the maintained v1.x (composer require --dev dealerdirect/phpcodesniffer-composer-installer:"^1.0") and set Composer's allow-plugins for the package. [1][2]

Sources:
[1] GitHub README (dealerdirect/phpcodesniffer-composer-installer) — compatibility statement.
[2] Packagist entry for dealerdirect/phpcodesniffer-composer-installer — requires php: >=5.4 and composer-plugin-api: ^2.2.

Plan: Remove PHP 8.5 incompatible packages from require-dev

Based on my analysis, drupal/coder is the only package in require-dev that:

Is potentially incompatible with PHP 8.5 (requires php >=7.2 but not explicitly tested on 8.5)
Is NOT needed for testing (only used for coding standards linting)

All other packages are either:

Compatible with PHP 8.5 (phpstan, rector, ergebnis/composer-normalize, bamarni/composer-bin-plugin, dealerdirect/phpcodesniffer-composer-installer)
Essential for testing and cannot be removed (phpunit)

I'll remove drupal/coder and dealerdirect/phpcodesniffer-composer-installer (which is only needed as a dependency for drupal/coder).

⏳ Preparing changes...

coderabbitai · 2025-09-30T13:31:45Z

A summary of the changes CodeRabbit can apply:

Update .github/workflows/test-php.yml to make PHP 8.5 install only production deps plus PHPUnit and skip composer validation and phpstan-based linting, while preserving full dev dependency installation and checks for other PHP versions so tests run on PHP 8.5 without phpstan.

Update .github/workflows/test-php.yml to replace plain "composer install" in multiple jobs with a multi-line conditional that for PHP 8.5 runs "composer install --no-dev" and "composer require --dev phpunit/phpunit:^11 --with-all-dependencies" (otherwise runs "composer install"), and add conditions to skip composer validation and coding-standards checks when matrix.php-versions = '8.5'.

Created local commit - (🔄 Check again to try again)

coderabbitai · 2025-09-30T13:32:08Z

A summary of the changes CodeRabbit can apply:

Update composer.json: remove PHP 8.5–incompatible dev packages (drupal/coder and dealerdirect/phpcodesniffer-composer-installer), drop the corresponding config.allow-plugins entry and phpcs/phpcbf lint scripts, retain PHP 8.5‑compatible dev packages (bamarni/composer-bin-plugin, ergebnis/composer-normalize, phpstan, phpunit, rector) and set scripts.lint-fix to only run "rector --clear-cache".

Update composer.json: remove dev packages dealerdirect/phpcodesniffer-composer-installer and drupal/coder and their allow-plugins entry, drop "phpcs" from the "lint" script, simplify "lint-fix" to only "rector --clear-cache", and keep the remaining dev requirements and scripts.

✅ Create PR with these edits
📌 Create commit in current branch
📋 Get copyable edits

coderabbitai · 2025-09-30T14:19:24Z

Creating a commit in the current branch to apply the edits...

The changes have been committed to the current branch. Commit ID: 552a144fdcfcd1b1394ca6d535a35232b178a074

Added PHP 8.5 to CI.

6e4fc2d

github-actions bot assigned AlexSkrypnyk Sep 11, 2025

AlexSkrypnyk force-pushed the feature/ci-php8.5 branch from 552a144 to 6e4fc2d Compare September 30, 2025 21:33

AlexSkrypnyk added the BLOCKED Issue or pull request is blocked label Sep 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Added PHP 8.5 to CI. #177

Added PHP 8.5 to CI. #177

Uh oh!

AlexSkrypnyk commented Sep 11, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Sep 11, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Uh oh!

AlexSkrypnyk commented Sep 30, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Sep 30, 2025

Uh oh!

coderabbitai bot commented Sep 30, 2025

Uh oh!

coderabbitai bot commented Sep 30, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Sep 30, 2025

Uh oh!

coderabbitai bot commented Sep 30, 2025

Uh oh!

Uh oh!

Uh oh!

Added PHP 8.5 to CI. #177

Are you sure you want to change the base?

Added PHP 8.5 to CI. #177

Uh oh!

Conversation

AlexSkrypnyk commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

AlexSkrypnyk commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Sep 30, 2025

Task: Conditionally remove PHP 8.5 incompatible packages in GitHub Actions

Uh oh!

coderabbitai bot commented Sep 30, 2025

Plan: Remove PHP 8.5 incompatible packages from require-dev

Uh oh!

coderabbitai bot commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Sep 30, 2025

Uh oh!

coderabbitai bot commented Sep 30, 2025

Uh oh!

Uh oh!

AlexSkrypnyk commented Sep 11, 2025 •

edited

Loading

coderabbitai bot commented Sep 11, 2025 •

edited

Loading

AlexSkrypnyk commented Sep 30, 2025 •

edited

Loading

coderabbitai bot commented Sep 30, 2025 •

edited

Loading