feat(search): Add GEO index and RADIUS search #5854
Draft
+203
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaruza
force-pushed
the
mkaruza/github#4536
branch
from
b9f3a30 to
a1a5f6a
Compare
dranikpg
reviewed
Sep 24, 2025
src/core/search/search.cc
Outdated
|
|
||
| IndexResult Search(const AstGeoNode& node, string_view active_field) { | ||
| DCHECK(!active_field.empty()); | ||
| double converted_radius = GeoIndex::ConvertToRadiusInMeters(node.radius, node.unit); |
There was a problem hiding this comment.
I'd make the index do that internally
mkaruza
force-pushed
the
mkaruza/github#4536
branch
from
e54ccac to
0c89126
Compare
dranikpg
previously approved these changes
Sep 26, 2025
Comment on lines
48
to
53
| struct AstGeoNode { | ||
| AstGeoNode(double lat, double lon, size_t radius, std::string unit); | ||
| double lat, lon; | ||
| size_t radius; | ||
| std::string unit; | ||
| }; |
There was a problem hiding this comment.
TODO: parse unit from lexer (so we can throw the error in time)
src/core/search/indices.cc
Outdated
Comment on lines
638
to
650
| double lat; | ||
| if (!absl::SimpleAtod(coordinates[0], &lat)) | ||
| return false; | ||
|
|
||
| double lon; | ||
| if (!absl::SimpleAtod(coordinates[1], &lon)) | ||
| return false; | ||
|
|
||
| entry index_entry = std::make_pair(point{lat, lon}, id); | ||
|
|
||
| rtree_->insert(index_entry); | ||
|
|
||
| return true; |
There was a problem hiding this comment.
Just style comment how to reduce volume 😅
// absl::StrSplit can split into a pair but you can't check there easily
double lon, lat;
if (!absl::SimpleAtod() || !absl::SimpleAtod())
return false;
rtree_->emplace(point{}, id)
return true;
src/core/search/indices.cc
Outdated
Comment on lines
700
to
711
| double lat; | ||
| if (!absl::SimpleAtod(coordinates[0], &lat)) { | ||
| return std::nullopt; | ||
| } | ||
|
|
||
| double lon; | ||
| if (!absl::SimpleAtod(coordinates[1], &lon)) { | ||
| return std::nullopt; | ||
| } | ||
|
|
||
| return point{lat, lon}; | ||
| } |
There was a problem hiding this comment.
Just style comment, feel free to ignore 😅
double lon, lat;
if (!absl::SimpleAtod() || !absl::SimpleAtod())
return nullopt;
src/core/search/indices.h
Outdated
Comment on lines
222
to
224
| std::vector<DocId> GetAllDocsWithNonNullValues() const override { | ||
| return std::vector<DocId>{}; | ||
| } |
There was a problem hiding this comment.
That need to be for a @geofield:* query? Is this possible? If not, we should explicitly disallow it. Not saying to solve it now, just a TODO would help us not to forget
src/core/search/indices.cc
Outdated
| } | ||
| } | ||
|
|
||
| std::optional<GeoIndex::point> GeoIndex::GetGeoPoint(const DocumentAccessor& doc, |
There was a problem hiding this comment.
Can be in anonymous namespace
dranikpg
reviewed
Sep 26, 2025
Fixes #4536 Signed-off-by: mkaruza <mario@dragonflydb.io>
mkaruza
force-pushed
the
mkaruza/github#4536
branch
2 times, most recently
from
567e33c to
33518a2
Compare
mkaruza
force-pushed
the
mkaruza/github#4536
branch
from
33518a2 to
8d6c4dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4536