Early support for django 6.0 - test against alpha 1 #237
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds early support for Django 6.0 by testing against Django 6.0a1 (alpha 1) and updating the package version to 3.3.2. The changes prepare the library for compatibility with the upcoming Django 6.0 release while maintaining backward compatibility with existing Django versions.
Key changes:
- Version bump from 3.3.1 to 3.3.2
- Expanded Django compatibility from
<6.0to<6.1 - Added CI testing for Django 6.0a1 with appropriate exclusions for unsupported Python versions
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/django_typer/init.py | Bumped package version to 3.3.2 |
| pyproject.toml | Updated Django dependency range and added Django 6.0 classifier |
| doc/source/changelog.rst | Added changelog entry for v3.3.2 release |
| .github/workflows/test.yml | Added Django 6.0a1 to test matrix with prerelease installation logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| run: | | ||
| just test-lock "Django~=${{ matrix.django-version }}.0" | ||
| just setup ${{ steps.sp.outputs.python-path }} | ||
| if [[ "${{ matrix.django-version }}" =~ (a|b|rc) ]]; then |
There was a problem hiding this comment.
The regex pattern (a|b|rc) may not match all possible Django prerelease patterns. Consider using a more comprehensive pattern like [0-9]+(a|b|rc)[0-9]* to ensure it matches specific alpha/beta/rc versions with numbers.
| if [[ "${{ matrix.django-version }}" =~ (a|b|rc) ]]; then | |
| if [[ "${{ matrix.django-version }}" =~ [0-9]+(a|b|rc)[0-9]* ]]; then |
Copilot uses AI. Check for mistakes.
No description provided.