Skip to content

Conversation

Kaiqgs
Copy link
Collaborator

@Kaiqgs Kaiqgs commented Sep 29, 2025

@Kaiqgs Kaiqgs marked this pull request as ready for review October 7, 2025 12:36

local function update_attributes(attr, dt, new_position)
if new_position.x ~= new_position.x or attr.position.x ~= attr.position.x then
return
Copy link
Collaborator Author

@Kaiqgs Kaiqgs Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason,nan vector errors were popping

@Kaiqgs Kaiqgs self-assigned this Oct 14, 2025
This was linked to issues Oct 14, 2025
Copy link

@britzl britzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please add which version of FMOD this extension is using in the readme? Let's add it as a GitHub "shield badge". Example:

https://github.com/defold/extension-steam/blob/master/README.md

@britzl britzl requested a review from ekharkunov October 15, 2025 06:41
Android has been updated to 2.03.09
Copy link

@ekharkunov ekharkunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: What about wasm_pthread-web support? In case if FMOD doesn't support pthread version of libraries for emscripten than we should add "stub" implementation for wasm_pthread-web like here
https://github.com/defold/extension-photon-realtime/blob/master/realtime/src/realtime.cpp#L1256-L1279

js-web:
context:
libs: ["fmodbridge", "fmodstudio"]
emscriptenLinkFlags: ["EXPORTED_RUNTIME_METHODS=[\"ccall\",\"callMain\",\"UTF8ToString\",\"HEAPU8\",\"stringToUTF8\",\"cwrap\"]"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess here should be getValue and setValue also?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FMOD 2.02 is out of date HTML5: Module.cwrap is not a function

3 participants