Skip to content

Conversation

aixaCode
Copy link
Collaborator

@aixaCode aixaCode commented Apr 29, 2024

What does this PR change?

Removes 0.75 offset in the avatar attach component.

After this is merge, we can merge back those changes decentraland/sdk7-goerli-plaza#167
This is the expected result:
Screenshot 2024-04-30 124929

This can introduce breaking change for some scenes.
With current live version the test scene will be broken and look like that

Screenshot 2024-04-30 125555

How to test the changes?

  1. Launch the explorer
  2. /changerealm https://sdk-team-cdn.decentraland.org/ipfs/goerli-plaza-fix-protocol-squad-1-latest
  3. Go to 75,-7
  4. check that the switched avatar model is aligned properly on the ground

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Copilot summary

copilot:summary

@aixaCode aixaCode added the do not merge This PR should not be merged because is experimental or for testing purposes. label Apr 30, 2024
@aixaCode aixaCode marked this pull request as ready for review April 30, 2024 11:57
@aixaCode aixaCode marked this pull request as draft April 30, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge This PR should not be merged because is experimental or for testing purposes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant