Convert median to percentile in metrics (like in measures) #433
+374
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4 tasks
theyostalservice
force-pushed
the
patricky/convert-median-for-metrics-too
branch
2 times, most recently
from
1da4cc1 to
6c223f5
Compare
4 tasks
courtneyholcomb
approved these changes
Sep 30, 2025
Merge activity
|
theyostalservice
changed the base branch from
patricky/median-measure-transformation-tests
to
graphite-base/433
theyostalservice
added a commit
that referenced
this pull request
Sep 30, 2025
Towards #387 ### Description We already convert measures with agg value MEDIAN to be percentile measures. Since we're replacing measures with simple metrics, #433 will do the same thing for simple metrics. Before that, it'd be helpful to have a test in place that shows that the existing legacy measure conversion work, and that's what this PR is for! ### Checklist - [x] I have read [the contributing guide](https://github.com/dbt-labs/dbt-semantic-interfaces/blob/main/CONTRIBUTING.md) and understand what's expected of me - [x] I have signed the [CLA](https://docs.getdbt.com/docs/contributor-license-agreements) - [x] This PR includes tests, or tests are not required/relevant for this PR - [ ] I have run `changie new` to [create a changelog entry](https://github.com/dbt-labs/dbt-semantic-interfaces/blob/main/CONTRIBUTING.md#adding-a-changelog-entry)
theyostalservice
force-pushed
the
patricky/convert-median-for-metrics-too
branch
from
6c223f5 to
15092b6
Compare
theyostalservice
deleted the
patricky/convert-median-for-metrics-too
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #387
Description
Depends on #432
We already convert measures with agg value MEDIAN to be percentile measures. Since we're replacing measures with simple metrics, this PR does the same for simple metrics.
Notes:
Checklist
changie newto create a changelog entry