fix(entity controller) Fix case sensitivity in entity controller #14902
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
devops
datahub-cyborg
bot
added
the
needs-review
Bundle ReportBundle size has no change ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
kevin1chun
approved these changes
Oct 1, 2025
datahub-cyborg
bot
added
merge-pending-ci
david-leifker
approved these changes
Oct 1, 2025
deepgarg760
reviewed
Oct 3, 2025
| for (String entityName : entityTypes) { | ||
|
|
||
| // Case-insensitive matching. | ||
| List<IngestResult> entityResults = resultsByEntityType.getOrDefault(entityName, List.of()); |
There was a problem hiding this comment.
@zhixuanjia we can always check for lower case here ?
cc: @david-leifker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Summary
Currently in the request body of
createGenericEntitiesAPI , the entity name is passed in as camel case likeFooBarbut the entity type stored in DB is lowercase such asurn:li:foobar:123. This results in empty list in the response.Fix
Perform case-insensitive matching on the result map key.