Introduce a new feature to establish base configurator for Profiler Assessment #1981
+277
−124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundarshankar89
changed the title
|
✅ 29/29 passed, 2 flaky, 1m23s total Flaky tests:
Running from acceptance #2397 |
sundarshankar89
changed the title
|
Merged #1940 in this co-authored by: @goodwillpunning |
sundarshankar89
requested review from
goodwillpunning,
m-abulazm and
gueniai
m-abulazm
reviewed
Sep 3, 2025
| logger.info(f"Creating a virtual environment for Python script execution: ${venv_dir}") | ||
| # Install dependencies in the virtual environment | ||
| # Define the paths to the virtual environment's Python and pip executables | ||
| if sys.platform == "win32": |
There was a problem hiding this comment.
we need to standardize this with databricks.labs.lakebridge.install.WheelInstaller._create_venv
please add a TODO for later
There was a problem hiding this comment.
- create_env
- activate env
- _install_dependencies
- _run_python_script
are all generic and can be extracted out to a common utility class
m-abulazm
requested changes
Sep 3, 2025
| "snowflake": SnowflakeConnector, | ||
| "mssql": MSSQLConnector, | ||
| "tsql": MSSQLConnector, | ||
| "synapse": MSSQLConnector, |
sundarshankar89
had a problem deploying
to
tool
GitHub Actions
Failure
sundarshankar89
had a problem deploying
to
tool
GitHub Actions
Failure
sundarshankar89
had a problem deploying
to
tool
GitHub Actions
Failure
sundarshankar89
had a problem deploying
to
tool
GitHub Actions
Failure
sundarshankar89
temporarily deployed
to
tool
GitHub Actions
Inactive
sundarshankar89
temporarily deployed
to
tool
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
What does this PR do?
Relevant implementation details
databricks labs lakebridge configure-database-profilerCaveats/things to watch out for when reviewing:
Linked issues
Resolves #..
Functionality
databricks labs lakebridge ...Tests