Refactor controller to follow hexagonal architecture principles #6
+2,279
−1,789
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CreatePostController
was violating hexagonal architecture principles by directly using Symfony HTTP response objects and methods, creating tight coupling between the UI layer and infrastructure concerns.Problem
The original controller implementation had several architectural violations:
This approach:
Solution
Introduced proper hexagonal architecture by creating domain interfaces and infrastructure implementations:
Domain Layer (Contracts)
HttpResponseFactoryInterface
- Contract for creating HTTP responsesHttpResponseInterface
- Contract representing HTTP responsesFlashMessageServiceInterface
- Contract for flash message handlingInfrastructure Layer (Symfony Implementations)
SymfonyHttpResponseFactory
- Creates responses using Symfony componentsSymfonyHttpResponse
- Wraps Symfony Response objectsSymfonyFlashMessageService
- Handles flash messages via Symfony sessionDomainResponseListener
- Event listener to convert domain responses back to Symfony responsesRefactored Controller
Benefits
The controller now exemplifies proper hexagonal architecture implementation where the domain defines contracts and infrastructure provides implementations, exactly as suggested in the original issue.
Fixes #3.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/symfony/runtime/zipball/9516056d432f8acdac9458eb41b80097da7a05c9
/usr/bin/php8.3 -n -c /tmp/axCKV6 /usr/bin/composer update
(http block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.