Richie/onboarding #92
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrPeterss
requested review from
MrPeterss
and removed request for
JaysonHahn and
MrPeterss
is this supposed to say jiwon i logged in with my own google account |
MrPeterss
requested changes
Sep 18, 2025
|
Yes, right now the profile tab is purely UI |
MrPeterss
approved these changes
Sep 22, 2025
| 2E39D82F2B3BCBA400AD238B /* UpliftAPI in Frameworks */, | ||
| 6338EC5C2CE149AA000BBFD3 /* UpliftAPI in Frameworks */, | ||
| 897DF9BA2CCDC49B00246B0D /* UpliftAPI in Frameworks */, | ||
| 897DF9BA2CCDC49B00246B0D /* (null) in Frameworks */, |
There was a problem hiding this comment.
do we know why this file has so many repeating hashes? or why this line was changed to (null)?
|
|
||
| // MARK: Restore Previous Sign-in | ||
|
|
||
| private func restoreUserSession() { |
There was a problem hiding this comment.
I'm not a huge fan of this function here. It would also be better if we could make this async/await rather than using completions. I think resell has a very solid sign in logic flow. Fine for now but we should look at it
| } | ||
| .store(in: &queryBag) | ||
| } | ||
|
|
There was a problem hiding this comment.
The restoreSignIn function should probably go in here as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.