-
Notifications
You must be signed in to change notification settings - Fork 31
Implements Notary Proofs #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Step7750
wants to merge
15
commits into
master
Choose a base branch
from
feature/notary-client
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of an arbitrary timer
You never know when users spam a button across multiple tabs
hacky workaround a panic when thread count is too high due to lack of destructors
GODrums
approved these changes
Sep 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few optional minor improvements. Overall, super impressive technology though.
@@ -0,0 +1,48 @@ | |||
const OFFSCREEN_DOCUMENT_PATH = '/src/offscreen.html'; | |||
|
|||
let creating: Promise<void> | null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mega-PR that provides E2E functionality for computing tlsn proofs. There will be a few follow ups for submitting proofs and auto-computing them in certain circumstances.
Overview:
NOTARY_PROVE
method for external communicationservice worker
<->offscreen
communicationFirefox is not supported: It appears to not be possible to set
Cross-Origin-Embedder-Policy
andCross-Origin-Opener-Policy
headers on the FF background page itself (dynamic MV3 header rewrite rules were a no-go as well). Given the small % that FF makes up on the site, we can likely shift them to the app to complete associated tasks.Note
Introduces TLSNotary proof generation with a new NOTARY_PROVE request, offscreen worker pipeline, and build/manifest updates (CSP, permissions, assets) to load WASM and enable multi-threading.
NOTARY_PROVE
request/handler (src/lib/bridge/handlers/notary_prove.ts
) with max concurrency, usingtlsn-js
to producepresentation
proofs.src/lib/notary/types.ts
,src/lib/notary/utils.ts
) and offscreen client bridge (src/offscreen/client.ts
).src/offscreen/offscreen.{html,ts}
), request routing (src/offscreen/handlers/*
), worker thread (src/offscreen/worker.ts
), and lifecycle utils (src/offscreen/utils.ts
).RequestType.NOTARY_PROVE
inhandlers.ts
and enums; addMaxConcurrency
wrapper incached.ts
.manifest.json
: addminimum_chrome_version
, permissionoffscreen
, and CSP for extension pages (allow WASM eval).webpack.config.js
: add offscreen entry, copy TLSN assets/snippets, provideBuffer
, set COOP/COEP headers for dev; filteroffscreen
permission for Firefox; add local hosts in dev.tsconfig.json
: update module toes2022
.environment*.ts
.wait(ms)
util.tlsn-js
,comlink
, andbuffer
(and associated WASM/snippets) to project.Written by Cursor Bugbot for commit 75e45c9. This will update automatically on new commits. Configure here.