-
Notifications
You must be signed in to change notification settings - Fork 31
Modernize project #739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Modernize project #739
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Mocking a connection is also simplified with a fixture. Aditionally two more tests were added.
|
Hi. Thanks for modernizing. We appreciate using testcontainers instead of testlayers and specifically to get rid of Zope-related packages from previous decades where maintenance seems to be fading. (see also GH-723, GH-725, GH-736) However, is it possible to split project infrastructure / metadata updates vs. those test modernizations which will have a much larger impact to the testing codebase, and also possibly migrate test cases progressively? We otherwise fear the patch will become too big to review reasonably, a problem we've currently encountered elsewhere. testcontainers/python-unittest demonstrates a way to use the modern testcontainers way of testing together with traditional Python unittest, intended to support this and other repositories on their modernization paths. Maybe this can help a bit on this occasion? CrateDBTestAdapter is effectively just a little wrapper using the CrateDBContainer class that is implementing the testcontainers specification, so it can be slotted into unittest layer concepts, at least as an intermediate workaround adapter for supporting a progressive migration, when possible. NB: In particular, |
Yes I can split the PR into -> metadata & tests. I put them together because reviewing a
My goal is to move to the current python standard which is to use
I kind of find it annoying, with just pytest every test need is pretty much solved, I don't think there is any need for it nowadays, migrating away from I understand that the review could be a bit painful but I think it's one of those that happen every few years that you just have to do it, I think that we are all very used to pytest and as you can see in the ones that I migrated, the resulting code is very light and shorter than the unitests', so I'd ask for a little bit of help soldiering here 🙏 |
This pr attempts to modernize the project by:
pyproject.tomlmoving away fromsetup.pypytestmoving away fromzopeandunittestsuvand any other pyproject.toml compatible toolsetup.pyshenanigansTestlayerto testcontainersChanges
setup.pytopyproject.tomluvand othervenvtools.uv buildandpython -m buildAditional changes
test_httpintotest_serializationandtest_client. This is just to give an idea of what the change is like, might actually differ later.Notes to remember: