Skip to content

Conversation

LecrisUT
Copy link
Contributor

@LecrisUT LecrisUT commented Sep 22, 2025

See:

An alternative design is to add the tests in .packit.yaml. Let me know which approach would be preferred. I don't quite follow the steps you do with podman-next*.repo, maybe we could look into that as well?

(should use only one PR where we discuss and test these)

Summary by Sourcery

New Features:

  • Add a new FMF plan file for tmt-based integration testing

Copy link

sourcery-ai bot commented Sep 22, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Introduce a new TMT-based integration test plan by adding a dedicated FMF configuration under plans/tmt.fmf, enabling standardized discovery and execution of integration tests for container-selinux.

File-Level Changes

Change Details Files
Add a new FMF-based integration testing plan using tmt
  • Create plans/tmt.fmf with FMF metadata (summary, tags, url)
  • Configure test discovery to use tmt run
  • Define execution steps to invoke tmt with required environment
  • Specify reporting and cleanup actions within the plan
plans/tmt.fmf

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lsm5 PTAL

See:
- teemtee/tmt#4047
- teemtee/tmt#4026

Signed-off-by: Cristian Le <git@lecris.dev>
@lsm5
Copy link
Member

lsm5 commented Sep 23, 2025

I don't quite follow the steps you do with podman-next*.repo, maybe we could look into that as well?

In .packit.yaml we add the podman-next repo and in the TMT plan we bump the priority so that podman and other packages will be fetched from podman-next copr instead of testing-farm-tag repository.

@lsm5
Copy link
Member

lsm5 commented Sep 23, 2025

An alternative design is to add the tests in .packit.yaml. Let me know which approach would be preferred.

I think the current setup is fine given the TMT tests finish in a matter of seconds IIUC, and assuming they won't flake.

Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This should help catch any potential breakages crun could cause on tmt.

I'll defer to @giuseppe and @flouthoc .

@giuseppe giuseppe merged commit 270c76a into containers:main Sep 23, 2025
48 checks passed
@LecrisUT
Copy link
Contributor Author

I don't quite follow the steps you do with podman-next*.repo, maybe we could look into that as well?

In .packit.yaml we add the podman-next repo and in the TMT plan we bump the priority so that podman and other packages will be fetched from podman-next copr instead of testing-farm-tag repository.

Hmm, I don't think we set any special repo priority, but it sounds like you want install.exclude and remove the testing-farm created repo? Anyway with the imported plans it could be dubious because you cannot inject those steps arbitrarily, so let's check that all is as expected on that front

@lsm5
Copy link
Member

lsm5 commented Sep 23, 2025

Hmm, I don't think we set any special repo priority, but it sounds like you want install.exclude and remove the testing-farm created repo? Anyway with the imported plans it could be dubious because you cannot inject those steps arbitrarily, so let's check that all is as expected on that front

There's the recent TMT RFE about better install tracking. Would that help toward this? Ideally, I'd prefer no priorities / equal priorities on all repos and let the user deal with it.

@lsm5
Copy link
Member

lsm5 commented Sep 23, 2025

Hmm, I don't think we set any special repo priority, but it sounds like you want install.exclude and remove the testing-farm created repo? Anyway with the imported plans it could be dubious because you cannot inject those steps arbitrarily, so let's check that all is as expected on that front

By default I've noticed testing-farm envs fetch packages from testing-farm tag repo even after a copr was enabled. I don't know if that's still the case.

@LecrisUT
Copy link
Contributor Author

By default I've noticed testing-farm envs fetch packages from testing-farm tag repo even after a copr was enabled. I don't know if that's still the case.

Still the case, but if you overwrite the artifacts completely, it should only do the copr enablement. Looking at the request, the original build artifacts are still there. I think you had a RFE on packit to allow to overwrite this? I will make a quick PR if you can point me to the design requirement you had in mind.

There's the recent TMT RFE about better install tracking. Would that help toward this? Ideally, I'd prefer no priorities / equal priorities on all repos and let the user deal with it.

Indeed there is, but I think with the design you have in mind for this, it is more on packit side to allow for the case above, and it should be possible in the current implementation. Specifically, we should be able to do this directly from testing-farm-cli and just strip out the rpm artifacts from the request above. Just need a second pair of eyes to check that everything is as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants