fix(deps): update module github.com/mistifyio/go-zfs/v3 to v4

[renovate]

This PR contains the following updates:

Package	Change	Age	Confidence
github.com/mistifyio/go-zfs/v3	v3.1.0 -> v4.0.0

---

Release Notes

mistifyio/go-zfs (github.com/mistifyio/go-zfs/v3)

v4.0.0

Compare Source

What's Changed

• Add -p flag in GetProperty in order to display numbers in parsable values by @​mmlb in #​85
• Update module to go-zfs/v4 by @​trisk in #​98

Diffstat

 go.mod               |  2 +-
 test_helpers_test.go |  2 +-
 zfs.go               |  2 +-
 zfs_test.go          | 12 +++++++-----
 4 files changed, 10 insertions(+), 8 deletions(-)

Shortlog

Albert Lee (2):
      test: Update creation time test for numeric properties
      Update module to go-zfs/v4

Nikos Gkotsis (1):
      Add -p flag in GetProperty in order to display numbers in parsable values

Full Changelog: mistifyio/go-zfs@v3.1.0...v4.0.0

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR was generated by Mend Renovate. View the repository job log.

[mtrmac]

Note to self: Renovate did not actually prepare an update PR, the bump to v4 needs to happen manually.

The major version bump is for mistifyio/go-zfs#85 ; AFAICS we never call that, but I’d appreciate a second pair of eyes on that.

[mtrmac]

Updated manually, please review.

[podmanbot]

✅ A new PR has been created in buildah to vendor these changes: containers/buildah#6410

[Luap99]

Note to self: Renovate did not actually prepare an update PR, the bump to v4 needs to happen manually.

Looks like renovate removed your import path update here so you need to push this again?

I recently saw there is actually a renovate config option to do that gomodUpdateImportPaths
https://docs.renovatebot.com/golang/#how-it-works

Maybe worth to try to enable that in our global config and see how that goes?

The major version bump is for mistifyio/go-zfs#85 ; AFAICS we never call that, but I’d appreciate a second pair of eyes on that.

I agree we should be safe to update.

[Luap99]

Opened containers/automation#257, I would like for that to get merged first to test if renovate can update the import path here because that would be pretty neat I think.

[renovate]

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

• any of the package files in this branch needs updating, or
• the branch becomes conflicted, or
• you click the rebase/retry checkbox if found above, or
• you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: storage/go.sum

Command failed: mod upgrade --mod-name=github.com/mistifyio/go-zfs/v3 -t=4
could not load package: err: exit status 1: stderr: go: inconsistent vendoring in /tmp/renovate/repos/github/containers/container-libs:
	github.com/containerd/stargz-snapshotter/estargz@v0.17.0: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/klauspost/compress@v1.18.0: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/vbatts/tar-split@v0.12.1: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/klauspost/compress@v1.18.0: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/containerd/stargz-snapshotter/estargz@v0.17.0: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/vbatts/tar-split@v0.12.1: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/klauspost/compress@v1.18.0: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/mistifyio/go-zfs/v4@v4.0.0: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/klauspost/compress@v1.18.1: is marked as explicit in vendor/modules.txt, but not explicitly required in a go.mod

	To ignore the vendor directory, use -mod=readonly or -mod=mod.
	To sync the vendor directory, run:
		go work vendor

[Luap99]

Well so much for that, the renovate config works but the tool doesn't seem to be able to ignore/handle non go files correctly? I guess we could make a PR to https://github.com/marwan-at-work/mod to fix the tool and hope renovate updates that eventually.

For now it still means manual update then, though what is in general more concerning that CI here passes without that bump. It seems there isn't any zfs tests not even build test for that configuration

[mtrmac]

though what is in general more concerning that CI here passes without that bump. It seems there isn't any zfs tests not even build test for that configuration

Yes, and I’m fine with that, but I would expect a go mod tidy && git status to be failing — and I can’t see where we are running that; I think we have lost (the equivalents of) hack/tree_status.sh during the migration to the monorepo.

[Luap99]

though what is in general more concerning that CI here passes without that bump. It seems there isn't any zfs tests not even build test for that configuration

Yes, and I’m fine with that, but I would expect a go mod tidy && git status to be failing — and I can’t see where we are running that; I think we have lost (the equivalents of) hack/tree_status.sh during the migration to the monorepo.

Right I add this in #291 but we had to give it up because of go.sum, I guess given we have it in gitignore now that PR can be pushed forward

[packit-as-a-service]

Packit jobs failed. @containers/packit-build please check.