-
Notifications
You must be signed in to change notification settings - Fork 34
feat: Adding filter_cdx and warc_by_cdx commands (2) #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
malteos
wants to merge
51
commits into
main
Choose a base branch
from
feat/warc-by-cdx
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,207
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==========================================
+ Coverage 95.89% 96.46% +0.57%
==========================================
Files 7 19 +12
Lines 876 1583 +707
==========================================
+ Hits 840 1527 +687
- Misses 36 56 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds two new commands to the CLI:
filter_cdx
: Filter CDX files based on a given URL or SURT white list.warc_by_cdx
: Fetch WARC files likewarc
but instead of filtering based on a single URL this commands filters based on a given CDX file.Both commands support reading and writing to local or remote paths (like S3) and gzip compression. To make the code more readable, parts of
cli.py
were moved toutils.py
.Example usage
Filter CDX files from S3 based on URL or SURT whitelist (input and output paths can be local or remote, e.g., S3):
Fetch WARC records based on filtered CDX (output is written to a local dir or S3)
For better throughput for S3 read/write, we have also a specific implementation using
aioboto3
that you can enable with the--implementation=aioboto3
argument:To maintain the filter inputs, e.g., the whitelist list, we can add one or multiple files with metadata as resource records to the extracted WARC. To do this, you need to provide the corresponding file paths as arguments
--write-paths-as-resource-records=s3://commoncrawl-dev/eot-archive/malte-test/ccf-gov-federal-web-graph-2024-jun-jul-aug.txt
and--write-paths-as-resource-records-metadata=path/to/metadata.json
. The metadata file is optional and can have the following optional fields:This in one example for a metadata JSON file:
The full WARC extraction command would look like this:
TODOs