Skip to content

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Oct 9, 2025

Description of Changes

This PR refactors various things in preparation for adding JS workers.
The changes are useful on their own without said workers and they are also their own PR for ease of review.

  1. Move all budget/timeout/energy/log-long-running logic to its own module.
  2. Extract some functions.
  3. register_hooks now validates early that __call_reducer__ and __describe_module__ exist and are functions. Validation beyond this is not possible with V8.

API and ABI breaking changes

None

Expected complexity level and risk

1

Testing

Mostly covered by existing tests...
Also, future work.

@Centril Centril requested a review from coolreader18 October 9, 2025 17:27
@Centril Centril changed the base branch from centril/v8-modules to master October 9, 2025 20:42
@Centril Centril force-pushed the centril/v8-js-worker-prepare branch from 68afdfd to 74db206 Compare October 9, 2025 21:14
@Centril Centril force-pushed the centril/v8-js-worker-prepare branch from 74db206 to 6d1cb88 Compare October 20, 2025 09:16
@Centril Centril force-pushed the centril/v8-js-worker-prepare branch from 6d1cb88 to c5fca89 Compare October 20, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-any To be landed in any release window

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants