Skip to content

Test overrides for custom builds of modeler #4616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft

Test overrides for custom builds of modeler #4616

wants to merge 6 commits into from
+15,329 −36,113

Conversation

nikku
Copy link
Member

@nikku nikku commented Oct 17, 2024

Proposed Changes

This uses overrides for consistent dependency linking:

  • add overrides config (a2e097f)
  • full rebuild of package-lock (35fa32b)

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

barmac and others added 6 commits October 16, 2024 09:35
@barmac
chore: adjust to del breaking change
58a92c9
@nikku
chore(client): update dependencies formatting
edcb6a0
@nikku
deps: update to diagram-js@14.11.3
79b7257
@nikku
chore: update package-lock to lockfileVersion=3
f14d2e7
@nikku
chore: configure override
a2e097f
@nikku
chore: rebuild package-lock
35fa32b 
Takes a long time, but gets the job done:

```
rm **/node_modules package-lock.json
npm install
```

After this, we see that only one version of diagram-js is used:

```
diagram-js": {
```

The one used is `15.0.0-alpha-keyboard`, as configured via override.
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Oct 17, 2024
@nikku nikku marked this pull request as draft October 17, 2024 08:55
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Oct 17, 2024
@nikku nikku changed the title Overrides Test overrides for custom builds of modeler Oct 17, 2024
@nikku nikku added the ready Ready to be worked on label Oct 29, 2024 — with bpmn-io-tasks
@nikku nikku added backlog Queued in backlog and removed in progress Currently worked on ready Ready to be worked on labels Oct 29, 2024
@nikku nikku removed their assignment Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backlog Queued in backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikku @barmac