fix: add @calcom/eslint-plugin to base ESLint config #24101
Draft
+6
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the ESLint warning in
packages/embeds/embed-core/src/embed.ts
where the rule@calcom/eslint/no-scroll-into-view-embed
was not found.The issue was that the
@calcom/eslint-plugin-eslint
package exists and contains the rule, but it wasn't imported and configured in the base ESLint configuration that all packages inherit from.Changes:
@calcom/eslint-plugin-eslint
as a workspace dependency to the eslint-config packagepackages/eslint-config/base.js
no-scroll-into-view-embed
rule that was causing the warningHow should this be tested?
Verify the fix:
npx eslint packages/embeds/embed-core/src/embed.ts
from the root directoryyarn lint:report
to ensure no regressions across all packagesyarn type-check:ci --force
to verify no type issues were introducedExpected behavior:
@calcom/eslint/no-scroll-into-view-embed
rulescrollIntoView
in embed contextsMandatory Tasks (DO NOT REMOVE)
Review Focus Areas
Key things to verify:
base.js
"@calcom/eslint"
matches the usage in embed.ts disable commentsLink to Devin run: https://app.devin.ai/sessions/7a1a6a69fc1240509debc80a872596b5
Requested by: @hariombalhara