Skip to content

Conversation

hariombalhara
Copy link
Member

What does this PR do?

Fixes the ESLint warning in packages/embeds/embed-core/src/embed.ts where the rule @calcom/eslint/no-scroll-into-view-embed was not found.

The issue was that the @calcom/eslint-plugin-eslint package exists and contains the rule, but it wasn't imported and configured in the base ESLint configuration that all packages inherit from.

Changes:

  • Added @calcom/eslint-plugin-eslint as a workspace dependency to the eslint-config package
  • Imported and configured the plugin in packages/eslint-config/base.js
  • Added the specific no-scroll-into-view-embed rule that was causing the warning

How should this be tested?

Verify the fix:

  1. Run npx eslint packages/embeds/embed-core/src/embed.ts from the root directory
  2. Confirm that the previous warning "Definition for rule '@calcom/eslint/no-scroll-into-view-embed' was not found" no longer appears
  3. Run yarn lint:report to ensure no regressions across all packages
  4. Run yarn type-check:ci --force to verify no type issues were introduced

Expected behavior:

  • ESLint should recognize the @calcom/eslint/no-scroll-into-view-embed rule
  • The rule should properly validate usage of scrollIntoView in embed contexts
  • No other ESLint or type checking errors should be introduced

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox. N/A - this is an internal ESLint configuration fix
  • I confirm automated tests are in place that prove my fix is effective or that my feature works. Verified via ESLint execution and lint:report

Review Focus Areas

Key things to verify:

  • ESLint plugin import syntax is correct in base.js
  • Plugin namespace "@calcom/eslint" matches the usage in embed.ts disable comments
  • Workspace dependency addition is appropriate for monorepo structure
  • No unintended side effects on other packages that inherit from base ESLint config

Link to Devin run: https://app.devin.ai/sessions/7a1a6a69fc1240509debc80a872596b5

Requested by: @hariombalhara

devin-ai-integration bot and others added 2 commits September 26, 2025 11:07
- Import @calcom/eslint-plugin-eslint in base ESLint configuration
- Add plugin to dependencies in eslint-config package
- Configure no-scroll-into-view-embed rule to resolve warning in embed.ts

Fixes ESLint warning: Definition for rule '@calcom/eslint/no-scroll-into-view-embed' was not found

Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com>
Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com>
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link
Contributor

coderabbitai bot commented Sep 26, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch devin/1758884558-fix-eslint-plugin-config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants