feat: run yarn install and playwright install concurrently in CI #24061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Split yarn-install.yml into parallel jobs for yarn and playwright installation - Update all E2E workflows to use inline concurrent installation with proper caching - Maintains existing caching strategies for both yarn and playwright - Should reduce CI build times by parallelizing package and browser binary downloads The key optimization is that yarn playwright install only needs package.json to determine the @playwright/test version, so it can run in parallel with yarn prisma generate after yarn install completes, rather than waiting for the full sequential chain. Co-Authored-By: keith@cal.com <keithwillcode@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Created composite action at .github/actions/yarn-install-concurrent/action.yml - Replaced duplicated installation logic across all E2E workflows - Maintains concurrent execution: yarn install -> (yarn prisma generate || yarn playwright install) - Preserves all existing caching strategies for yarn and playwright - Improves maintainability by centralizing installation logic Co-Authored-By: keith@cal.com <keithwillcode@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
- Eliminated code duplication by reusing caching patterns from existing actions - Maintains concurrent execution: yarn install -> (yarn prisma generate || yarn playwright install) - Preserves all existing caching strategies for yarn and playwright - Reduces action complexity while improving maintainability - Added clear documentation showing which patterns come from yarn-install and yarn-playwright-install actions Co-Authored-By: keith@cal.com <keithwillcode@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR optimizes CI build times by running
yarn installandyarn playwright installconcurrently instead of sequentially. It creates a new reusable composite action that consolidates the installation logic while eliminating code duplication across E2E workflows.Performance improvement: Instead of waiting for yarn install → yarn prisma generate → yarn playwright install sequentially, this runs yarn install → (yarn prisma generate || yarn playwright install) in parallel, reducing total installation time.
Key changes:
.github/actions/yarn-install-concurrent/action.yml- a new composite action that combines yarn and playwright installation with concurrent executione2e.yml,e2e-app-store.yml,e2e-embed.yml,e2e-embed-react.yml,merge-reports.yml) to use the new consolidated actionyarn-installandyarn-playwright-installactionsRequested by: @keithwillcode
Link to Devin run: https://app.devin.ai/sessions/010f7203b7df41b0824cb2d27cbff829
How should this be tested?
yarn prisma generateandyarn playwright install --with-depscan run safely in parallelMandatory Tasks (DO NOT REMOVE)
Critical Review Points
Caching correctness: The new action replicates caching logic from
yarn-installandyarn-playwright-install. Verify cache keys and paths match exactly.Concurrent execution safety: Confirm that running
yarn prisma generateandyarn playwright install --with-depsin parallel doesn't cause race conditions or dependency issues.Environment variables: Check that all required environment variables from the original actions are preserved in the new action.
E2E pipeline health: Monitor that all E2E workflows continue to pass consistently with the new concurrent installation.
Checklist