Cypress Build Unification #1002
Merged
+615
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tanmay-Bstack
requested review from
07souravkunda and
karanshah-browserstack
and removed request for
07souravkunda and
karanshah-browserstack
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
osho-20
reviewed
Sep 16, 2025
bin/testhub/testhubHandler.js
Outdated
| } | ||
| } | ||
|
|
||
| module.exports = TestHubHandler; No newline at end of file |
bin/testhub/utils.js
Outdated
| accessibility: accessibilityScanInfo[testData.name], | ||
| }; | ||
| } | ||
| }; No newline at end of file |
| exports.isAccessibilityEnabled = () => { | ||
| if (process.env.BROWSERSTACK_TEST_ACCESSIBILITY !== undefined) { | ||
| return process.env.BROWSERSTACK_TEST_ACCESSIBILITY === "true"; | ||
| } |
There was a problem hiding this comment.
Please add a log here for better clarity
| this.platformDetailsMap = {}; | ||
| this.runStatusMarkedHash = {}; | ||
| this.haveSentBuildUpdate = false; | ||
| this.startHttpServer(); |
There was a problem hiding this comment.
keep it in try catch if any how it fails to start and throw error
There was a problem hiding this comment.
Added try catch block inside the function
osho-20
previously approved these changes
Sep 19, 2025
osho-20
previously approved these changes
Sep 22, 2025
RutvikChandla
previously approved these changes
Sep 24, 2025
osho-20
previously approved these changes
Oct 3, 2025
RutvikChandla
previously approved these changes
Oct 3, 2025
AakashHotchandani
dismissed stale reviews from RutvikChandla and osho-20
via
9c8ae06
dhruvin-bs
previously approved these changes
Oct 8, 2025
rounak610
previously approved these changes
Oct 8, 2025
osho-20
previously approved these changes
Oct 8, 2025
RutvikChandla
previously approved these changes
Oct 8, 2025
AakashHotchandani
dismissed stale reviews from RutvikChandla, osho-20, rounak610, and dhruvin-bs
via
a28f8bc
AakashHotchandani
requested review from
RutvikChandla,
dhruvin-bs,
osho-20 and
rounak610
osho-20
approved these changes
Oct 9, 2025
pri-gadhiya
approved these changes
Oct 9, 2025
dhruvin-bs
approved these changes
Oct 9, 2025
rounak610
approved these changes
Oct 9, 2025
RutvikChandla
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.