Skip to content

Conversation

zfields
Copy link
Contributor

@zfields zfields commented Oct 17, 2025

  • Updates note-c for improved threading behavior

@zfields zfields requested review from Bucknalla and Copilot October 17, 2025 00:16
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Version bump to 1.8.2 and adjustments to transaction timeout and lock/reset sequencing for improved threading behavior.

  • Incremented C and Arduino library patch versions.
  • Modified transaction timeout calculation to always add an extra second and removed a prior 90-second fallback.
  • Reordered Notecard lock acquisition to occur before I/O reset and changed reset implementation (_Reset plus assignment in conditional).

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
src/note-c/note.h Bumps NOTE_C patch version macro to 3.
src/note-c/n_request.c Alters timeout logic and moves reset under the Notecard lock; replaces NoteReset() with _Reset().
src/NoteDefines.h Bumps Arduino library patch version macro to 2.
library.properties Updates published Arduino library version to 1.8.2.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@zfields zfields merged commit 96a8a97 into master Oct 17, 2025
95 checks passed
@zfields zfields deleted the zak-upd branch October 17, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant