Skip to content

Conversation

zfields
Copy link
Contributor

@zfields zfields commented Oct 10, 2025

No description provided.

@zfields zfields requested review from Bucknalla and Copilot October 10, 2025 17:10
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates Arduino-specific API calls to note-c abstraction functions for better code consistency and maintainability across different platforms. The changes replace direct Arduino function calls with their note-c counterparts while maintaining the same functionality.

  • Replaced ::millis() calls with NoteGetMs() for time measurement
  • Replaced ::delay() calls with NoteDelayMs() for delays
  • Updated include structure to use "Notecard.h" instead of "NoteDefines.h"

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/NoteTxn_Arduino.cpp Added Notecard.h include and replaced Arduino timing functions with note-c abstractions
src/NoteSerial_Arduino.cpp Updated include and replaced millis() with NoteGetMs() in serial timeout loop
src/NoteI2c_Arduino.hpp Removed unnecessary Notecard.h include
src/NoteI2c_Arduino.cpp Added Notecard.h include and replaced delay() calls with NoteDelayMs()

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@zfields zfields marked this pull request as draft October 10, 2025 17:12
Several test broke when moving from native Arduino
calls to  based abstractions
@zfields zfields marked this pull request as ready for review October 16, 2025 23:23
@zfields zfields merged commit e8e1cda into master Oct 16, 2025
94 checks passed
@zfields zfields deleted the zak-api branch October 16, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant