-
Notifications
You must be signed in to change notification settings - Fork 195
Add SIMPLIFLYH7 #927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add SIMPLIFLYH7 #927
Conversation
Warning Rate limit exceeded@haslinghuis has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 21 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughAdds a new board configuration header for SIMPLIFLYH7 (STM32H743) defining MCU/board/manufacturer IDs, feature flags, pin mappings (motors, UART, SPI, I2C, ADC, peripherals), timer mappings, DMA/SPI/I2C instances, defaults (blackbox/meter), and gyro SPI/EXTI/align settings. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
32ff205
to
1287efd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- blind approval
#define MOTOR5_PIN PB6 | ||
#define MOTOR6_PIN PB7 | ||
#define MOTOR7_PIN PD14 | ||
#define MOTOR8_PIN PD15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This design was approved before new rules came into effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the approved schematic, these are servo outputs, not motors.
What manufacturer is this? Can you link me to the Discord channel? |
@ot0tot macfos |
Co-authored-by: ot0tot <36753790+ot0tot@users.noreply.github.com>
Updated current meter scale and PINIO1_BOX value.
Am I looking at the right schematic? Flash uses QuadSPI. |
Co-authored-by: ot0tot <36753790+ot0tot@users.noreply.github.com>
@ot0tot you received a prototype as quad spi was left out IIRC. |
Checklist
Summary by CodeRabbit