Skip to content

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Oct 15, 2025

Checklist

  • passed schematics review
  • passed hardware samples testing
  • follows guidelines
  • follows connector standards
  • flight tested
  • comments/issues resolved

Summary by CodeRabbit

  • New Features
    • Added support for the SIMPLIFLYH7 flight controller.
    • Enables on-board gyro/accelerometer (SPI), barometer, OSD, and integrated blackbox flash.
    • Preconfigured for up to 8 motor outputs, multiple UARTs, I2C/SPI buses, status LED, beeper, and LED strip.
    • Camera control, PinIO with a VTX power toggle, and timer-channel pin mappings.
    • ADC-based voltage/current sensing with default scaling and blackbox-to-flash logging.

@haslinghuis haslinghuis self-assigned this Oct 15, 2025
Copy link
Contributor

coderabbitai bot commented Oct 15, 2025

Warning

Rate limit exceeded

@haslinghuis has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 21 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between fd9bcaf and 3759599.

📒 Files selected for processing (1)
  • configs/SIMPLIFLYH7/config.h (1 hunks)

Walkthrough

Adds a new board configuration header for SIMPLIFLYH7 (STM32H743) defining MCU/board/manufacturer IDs, feature flags, pin mappings (motors, UART, SPI, I2C, ADC, peripherals), timer mappings, DMA/SPI/I2C instances, defaults (blackbox/meter), and gyro SPI/EXTI/align settings.

Changes

Cohort / File(s) Summary of Changes
Board config: SIMPLIFLYH7
configs/SIMPLIFLYH7/config.h
New board config header. Declares FC_TARGET_MCU, BOARD_NAME, MANUFACTURER_ID; enables sensors/peripherals (USE_GYRO, USE_ACC, USE_BARO, USE_MAX7456, USE_FLASH, etc.); defines motor/LED/UART/I2C/SPI/ADC/BEEPER/CAMERA/PINIO pins and CS/EXTI pins; adds TIMER_PIN_MAPPING entries; sets DMA options (SPI3_TX_DMA_OPT, ADC1_DMA_OPT, ADC3_DMA_OPT), SPI/I2C instance macros, default blackbox/current/voltage meter sources and scale, BEEPER_INVERTED, flash/MAX7456 SPI instances, PINIO/BOX defaults, and gyro macros (GYRO_1_SPI_INSTANCE, GYRO_1_EXTI_PIN, GYRO_1_CS_PIN, GYRO_1_CLKIN_PIN, GYRO_1_ALIGN).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • add AEROH7DIGITAL #900 — Adds another STM32H743 board config header with overlapping motor/pin, TIMER_PIN_MAPPING, DMA and gyro SPI/alignment macros.
  • Add HAKRCH743 #757 — Introduces an STM32H743 board config defining similar sensor flags, SPI/I2C instances, DMA/default settings and gyro alignment macros.
  • Add SFLY manufacturer to the list #898 — Adds MANUFACTURER_ID entry for SFLY, directly related to the new board's manufacturer declaration.

Suggested labels

New manufacturer

Suggested reviewers

  • ot0tot
  • nerdCopter
  • blckmn

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description is largely incomplete compared to the required template. The author has only provided a partial checklist without the mandatory sections specified in the template, including the "Mandatory Review for All New Flight Controllers" requirements, "Hardware Compliance Requirements" section, "Housekeeping" notes, and any actual description of the hardware being added. Additionally, critical context such as the manufacturer name ("macfos") appears only in a comment thread rather than in the PR description itself, and important metadata is missing from the main description body. Update the pull request description to follow the provided template structure. Include the full mandatory requirements sections, hardware compliance references, housekeeping notes, and provide a comprehensive description of the SIMPLIFLYH7 board and manufacturer details. Ensure the complete checklist with all required items is properly documented in the description itself rather than relying on comment threads for critical information.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title "Add SIMPLIFLYH7" directly corresponds to the main change in the pull request, which adds a new board configuration header for the SIMPLIFLYH7 target. The title is concise, clear, and specific enough that a reviewer scanning the history would immediately understand that a new board configuration is being introduced. It avoids vague terms and noise while accurately reflecting the primary objective of the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • blind approval

#define MOTOR5_PIN PB6
#define MOTOR6_PIN PB7
#define MOTOR7_PIN PD14
#define MOTOR8_PIN PD15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This design was approved before new rules came into effect.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the approved schematic, these are servo outputs, not motors.

@ot0tot
Copy link
Contributor

ot0tot commented Oct 19, 2025

What manufacturer is this? Can you link me to the Discord channel?

@haslinghuis
Copy link
Member Author

@ot0tot macfos

haslinghuis and others added 2 commits October 19, 2025 22:26
Co-authored-by: ot0tot <36753790+ot0tot@users.noreply.github.com>
Updated current meter scale and PINIO1_BOX value.
@ot0tot
Copy link
Contributor

ot0tot commented Oct 19, 2025

Am I looking at the right schematic? Flash uses QuadSPI.

Co-authored-by: ot0tot <36753790+ot0tot@users.noreply.github.com>
@haslinghuis
Copy link
Member Author

@ot0tot you received a prototype as quad spi was left out IIRC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants