WIP: rules_swift 4.x base #1571
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
force-pushed
the
luis/4.x
branch
from
dcfa600 to
16ac29c
Compare
|
Just curious: what's the motivation to remove incremental compilation? |
|
It's removed in Google's upstream branch. More context / us asking for feedback: https://bazelbuild.slack.com/archives/CD3QY5C2X/p1758578665272229. |
luispadron
force-pushed
the
luis/4.x
branch
from
eb61b99 to
16ac29c
Compare
…is being used. Unless cross-module-optimization is disabled (which we don't really support at this time), the driver in this case will create a single frontend invocation that emits both the module and performs codegen. Cherry-pick of upstream: 29f0ec2
luispadron
force-pushed
the
luis/4.x
branch
from
36bd2a6 to
370db70
Compare
…ty string instead of the full list of object files. This reduces unnecessary processing for huge modules with hundreds of source files. Cherry-pick: c413bd3
luispadron
force-pushed
the
luis/4.x
branch
from
2eaa35b to
813f483
Compare
…p specific mnemonics.
luispadron
force-pushed
the
luis/4.x
branch
2 times, most recently
from
9eee21a to
87abef8
Compare
…mization modes interact as we expect. The tests highlight a couple cases that are currently known to be wrong so we can fix and test them without just manually building all possible combinations. Chery-pick: f6302a2
Explicitly disable cross-module optimization in `exec` configs so that Swift tools can be built in parallel to speed up critical build paths. Cherry-pic: d1ecc8a
Signed-off-by: Brentley Jones <github@brentleyjones.com>
…llel compilation. In the future, we should consider whether we should more strictly control where these flags can be applied, since they don't just control optimizations but also how the driver plans its work. Cherry-pick: ab55a12
…sed and `-wmo` is passed on the command line. Cherry-pick: 66a6a6b
luispadron
force-pushed
the
luis/4.x
branch
from
87abef8 to
6ab4bec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
abseil(bzlmod and WORKSPACE)re2(bzlmod and WORKSPACE)swift_runnercode (and related util) from upstream