Skip to content

refactor : parse websocket url via clop instead of runtime #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

refactor : parse websocket url via clop instead of runtime #106

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f3d30d7
Update main.rs
DoTheBestToGetTheBest Sep 28, 2025
840dacd
Update main.rs
DoTheBestToGetTheBest Sep 28, 2025
1a171b2
Update main.rs
DoTheBestToGetTheBest Sep 28, 2025
2a29744
Update main.rs
DoTheBestToGetTheBest Sep 28, 2025
8073113
Update main.rs
DoTheBestToGetTheBest Sep 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions crates/node/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,12 @@ struct Args {
#[command(flatten)]
pub rollup_args: RollupArgs,

#[arg(long = "websocket-url", value_name = "WEBSOCKET_URL")]
pub websocket_url: Option<String>,
#[arg(
long = "websocket-url",
value_name = "WEBSOCKET_URL",
value_parser = clap::value_parser!(Url)
)]
pub websocket_url: Option<Url>,

/// Enable transaction tracing ExEx for mempool-to-block timing analysis
#[arg(
Expand All @@ -48,6 +52,7 @@ struct Args {
}

impl Args {
#[inline]
fn flashblocks_enabled(&self) -> bool {
self.websocket_url.is_some()
}
Expand Down