Skip to content

Conversation

soheimam
Copy link
Collaborator

What changed? Why?

  • search and discovery updated
  • streamlined by removing duplicated information
  • added content voice and tone guide

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 12, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link
Collaborator

@ericbrown99 ericbrown99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments. The "Embed & Previews" page likely shouldn't be changed

The "Search & Discovery" page needs to be reconsidered, see comment on the doc below

@cb-heimdall cb-heimdall dismissed ericbrown99’s stale review October 14, 2025 09:30

Approved review 3333337933 from ericbrown99 is now dismissed due to new commit. Re-request for approval.

title: How Search works
description: If your Mini App isn't appearing in The Base app, this guide explains how indexing and search work so you can identify and fix the issue.
---
Indexing is how The Base app adds your Mini App to its catalog, making it discoverable through search and browsing.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The" -> "the" Base app

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add to our contribution guide the correct use the Base app so that it auto checks for us

</Warning>
</Step>
<Step title="Your app enters the directory">
Your Mini App is recorded and becomes searchable within 10 minutes.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have any internal data or metrics which give us confidence that this is actually true, the within 10 minutes part?



## How search works
The Base app's search queries your Mini App's `name` field from the catalog. Both exact and partial matches appear in results. Search displays your Mini App based on information you provided in your manifest.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when at the start of the sentence where "The" is capitalized because its the first word, "App" also needs to be capitalized.

So this should be: "The Base App's search..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants