-
Notifications
You must be signed in to change notification settings - Fork 206
search-discovery #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
search-discovery #490
Conversation
🟡 Heimdall Review Status
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments. The "Embed & Previews" page likely shouldn't be changed
The "Search & Discovery" page needs to be reconsidered, see comment on the doc below
Approved review 3333337933 from ericbrown99 is now dismissed due to new commit. Re-request for approval.
title: How Search works | ||
description: If your Mini App isn't appearing in The Base app, this guide explains how indexing and search work so you can identify and fix the issue. | ||
--- | ||
Indexing is how The Base app adds your Mini App to its catalog, making it discoverable through search and browsing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The" -> "the" Base app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should add to our contribution guide the correct use the Base app so that it auto checks for us
</Warning> | ||
</Step> | ||
<Step title="Your app enters the directory"> | ||
Your Mini App is recorded and becomes searchable within 10 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have any internal data or metrics which give us confidence that this is actually true, the within 10 minutes part?
|
||
|
||
## How search works | ||
The Base app's search queries your Mini App's `name` field from the catalog. Both exact and partial matches appear in results. Search displays your Mini App based on information you provided in your manifest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when at the start of the sentence where "The" is capitalized because its the first word, "App" also needs to be capitalized.
So this should be: "The Base App's search..."
What changed? Why?