Skip to content

Update index.d.ts #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update index.d.ts #31

wants to merge 1 commit into from

Conversation

krishanJat
Copy link

commit last line

@krishanJat
Update index.d.ts
8810404 
commit last line
@adambusfy123
Copy link

@CodiumAI-Agent /improve

@CodiumAI-Agent
Copy link

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Impact
Possible issue
Restore removed public type

Uncomment the ExchangeMetadata type so downstream TypeScript consumers retain proper
typings. Commenting out a public type is a breaking change and will cause type
errors where it is referenced.

index.d.ts [848-852]

-// type ExchangeMetadata = {
-//     id: string;
-//     description: string;
-//     timezone: string;
-// };
+type ExchangeMetadata = {
+    id: string;
+    description: string;
+    timezone: string;
+};
Suggestion importance[1-10]: 8

__

Why: The PR comments out the public ExchangeMetadata type (lines 848–852), which is a breaking change for TS consumers; restoring it preserves typings. The fix directly matches the new hunk and accurately reintroduces the removed type.

Medium

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krishanJat @adambusfy123 @CodiumAI-Agent