Increase multipart upload default part size to 8MB #4032
+21
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do we have any existing test cases that would use the default value that we could verify somehow the part size is 8MB? or did you somehow test manually to verify things? |
| partSize = S3Constants.MinPartSize; | ||
| } | ||
| // SEP Formula: Math.Max(targetPartSize, contentLength / 10_000) | ||
| long calculatedSize = Math.Max(targetPartSize, contentLength / 10_000); |
There was a problem hiding this comment.
this one is my fault. i think in the ticket i replaced s3constants.maxnumberofparts just to be more clear but S3Constants.MaxNumberOfParts is equal to 10,000 so we should use the constant
| "services": [ | ||
| { | ||
| "serviceName": "S3", | ||
| "type": "patch", |
There was a problem hiding this comment.
im thinking we should make this minor since its a change in behavior thats somewhat signifcant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increasing the default part size for S3 multipart upload from 5MB to 8MB when no part size is specified. This will reduce the number of API calls for multipart uploads.
Motivation and Context
DOTNET-8273
Testing
Ran dry run and it succeeded
Screenshots (if appropriate)
Types of changes
Checklist
License