Terraform template for AWS Step Functions workflow to integrate with Amazon Comprehend for sentiment analysis #2805

awsrahulrsr · 2025-07-29T12:10:38Z

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

awsrahulrsr · 2025-08-27T10:46:08Z

Hi Team,
Checking if this pull request can be merged?

biswanathmukherjee · 2025-10-09T13:55:59Z

sfn-comprehend-terraform/main.tf

+        "logs:DescribeResourcePolicies",
+        "logs:DescribeLogGroups"
+      ],
+      Resource = "*"


Can this be more restrictive than providing access to all resources ("*")?

As per this documentation we need to use "*". I tried to restrict it but terraform --apply fails with access denied to log group error.

biswanathmukherjee · 2025-10-09T13:56:14Z

sfn-comprehend-terraform/main.tf

+        "comprehend:BatchDetectDominantLanguage",
+        "comprehend:BatchDetectSentiment"
+      ],
+      Resource = "*"


Can this be more restrictive than providing access to all resources ("*")?

Here the calls like Detect sentiment, Detect Entities cannot be resource level ARN's.. hence I've used "*"

biswanathmukherjee · 2025-10-09T13:57:22Z

sfn-comprehend-terraform/README.md

@@ -0,0 +1,92 @@
+# AWS Step Functions Express Workflow to Amazon Comprehend for Sentiment Analysis  
+
+The Step Functions Express Workflow can be started using the AWS CLI or from another service (e.g. API Gateway) to run an express workflow and return the result.


Amazon API Gateway

biswanathmukherjee · 2025-10-09T14:00:47Z

sfn-comprehend-terraform/README.md

+
+The Step Functions Express Workflow can be started using the AWS CLI or from another service (e.g. API Gateway) to run an express workflow and return the result.
+
+The Terraform template deploys a Step Functions Express workflow that invokes Amazon Comprehend and returns the sentiment analysis done by Comprehend in the response. The Terraform template contains the required resouces with IAM permission to run the application with logging enabled.


Please replace Comprehend with Amazon Comprehend everywhere. The prefix is required everywhere.

biswanathmukherjee · 2025-10-09T14:06:40Z

sfn-comprehend-terraform/README.md

+3. From the command line, use Terraform to deploy the AWS resources for the pattern as specified in the main.tf file:
+    ```
+    terraform init
+    terraform apply --auto-approve


I got this error when running apply command.

│ Error: Reference to undeclared input variable
│
│ on main.tf line 14, in resource "aws_iam_role" "states_execution_role":
│ 14: Service = "states.${var.aws_region}.amazonaws.com"
│
│ An input variable with the name "aws_region" has not been declared. This variable can be declared with a variable
│ "aws_region" {} block.

biswanathmukherjee · 2025-10-09T14:08:21Z

sfn-comprehend-terraform/example-pattern.json

@@ -0,0 +1,65 @@
+{
+  "title": "AWS Step Functions Express Workflow to Amazon Comprehend for Sentiment Analysis",
+  "description": "The Terraform template deploys a Step Functions Express workflow that invokes Amazon Comprehend and returns the sentiment analysis done by Comprehend in the response. The SAM template contains the required resouces with IAM permission to run the application with logging enabled.",


resouces --> resources

biswanathmukherjee · 2025-10-09T14:11:30Z

sfn-comprehend-terraform/README.md

@@ -0,0 +1,92 @@
+# AWS Step Functions Express Workflow to Amazon Comprehend for Sentiment Analysis  


title does not meet maximum length of 75

biswanathmukherjee · 2025-10-09T14:12:42Z

sfn-comprehend-terraform/example-pattern.json

@@ -0,0 +1,65 @@
+{
+  "title": "AWS Step Functions Express Workflow to Amazon Comprehend for Sentiment Analysis",
+  "description": "The Terraform template deploys a Step Functions Express workflow that invokes Amazon Comprehend and returns the sentiment analysis done by Comprehend in the response. The SAM template contains the required resouces with IAM permission to run the application with logging enabled.",


description does not meet maximum length of 150

biswanathmukherjee · 2025-10-09T14:12:58Z

sfn-comprehend-terraform/example-pattern.json

@@ -0,0 +1,65 @@
+{
+  "title": "AWS Step Functions Express Workflow to Amazon Comprehend for Sentiment Analysis",


title does not meet maximum length of 75

biswanathmukherjee · 2025-10-09T14:24:23Z

sfn-comprehend-terraform/example-pattern.json

+      "repoURL": "https://github.com/aws-samples/serverless-patterns/tree/main/sfn-comprehend-terraform",
+      "templateURL": "serverless-patterns/sfn-comprehend-terraform",
+      "projectFolder": "sfn-comprehend-terraform",
+      "templateFile": "sfn-comprehend-terraform/main.tf"


Please remove the projectFolder value from the templateFile

biswanathmukherjee · 2025-10-15T14:22:19Z

Approving from pattern guardian perspective. DA will review and merge as per the next steps.

Terraform template Step Functions with comprehend

09a2efa

julianwood assigned biswanathmukherjee and julianwood Jul 29, 2025

biswanathmukherjee requested changes Oct 9, 2025

View reviewed changes

biswanathmukherjee added the requested-changes label Oct 9, 2025

Rahul Sringeri and others added 4 commits October 13, 2025 17:30

Addressed feedback comments that were provided for pull request # 2805

70172ed

updated as per feedback comments in PR aws-samples#2805

4928ebc

removed account number

66e4edb

Create sfn-comprehend-terraform.json

b6f5be7

biswanathmukherjee added Patterns Guardian approved and removed requested-changes labels Oct 15, 2025

awsrahulrsr added 2 commits October 15, 2025 16:47

Update README.md

21b9165

Update example-pattern.json

e30f563

		@@ -0,0 +1,92 @@
		# AWS Step Functions Express Workflow to Amazon Comprehend for Sentiment Analysis

		The Step Functions Express Workflow can be started using the AWS CLI or from another service (e.g. API Gateway) to run an express workflow and return the result.


		The Step Functions Express Workflow can be started using the AWS CLI or from another service (e.g. API Gateway) to run an express workflow and return the result.

		The Terraform template deploys a Step Functions Express workflow that invokes Amazon Comprehend and returns the sentiment analysis done by Comprehend in the response. The Terraform template contains the required resouces with IAM permission to run the application with logging enabled.

		@@ -0,0 +1,65 @@
		{
		"title": "AWS Step Functions Express Workflow to Amazon Comprehend for Sentiment Analysis",

Terraform template for AWS Step Functions workflow to integrate with Amazon Comprehend for sentiment analysis #2805

Are you sure you want to change the base?

Terraform template for AWS Step Functions workflow to integrate with Amazon Comprehend for sentiment analysis #2805

Uh oh!

Conversation

awsrahulrsr commented Jul 29, 2025

Uh oh!

awsrahulrsr commented Aug 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

biswanathmukherjee commented Oct 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants