Skip to content

Linear extrude2 #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Linear extrude2 #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8fcc64
clean doc
damrem Nov 27, 2016
beeb6fa
Merge remote-tracking branch 'remotes/away3d/master'
damrem Nov 27, 2016
9144a49
fix LinearExtrude.hx buildExtrude method initial condition
damrem Nov 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions away3d/extrusions/LinearExtrude.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,13 +106,13 @@ class LinearExtrude extends Mesh {
this.thicknessSubdivision = thicknessSubdivision;
_ignoreSides = ignoreSides;
_closePath = closePath;
super(geom, material);
if (materials != null) this.materials = materials;
if (_closePath && ignoreSides != "") this.ignoreSides = ignoreSides;
super(geom, material);
}

private function buildExtrude():Void {
if (_aVectors!=null && _aVectors.length > 0 && _aVectors.length < 2) throw new Error("LinearExtrusion error: at least 2 vector3D required!");
if (_aVectors==null || (_aVectors.length > 0 && _aVectors.length < 2)) throw new Error("LinearExtrusion error: at least 2 vector3D required!");
if (_closePath) _aVectors.push(new Vector3D(_aVectors[0].x, _aVectors[0].y, _aVectors[0].z));
_maxIndProfile = _aVectors.length * 9;
_MaterialsSubGeometries = null;
Expand Down
1 change: 0 additions & 1 deletion away3d/primitives/PrimitiveBase.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class PrimitiveBase extends Geometry {
private var _subGeometry:CompactSubGeometry;
/**
* Creates a new PrimitiveBase object.
* @param material The material with which to render the object
*/
public function new() {
super();
Expand Down