[FLINK-38418][python] Support pickling Instants when collecting TIMESTAMP_LTZ types in PyFlink #27048
+19
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Currently, when trying to
collect
aTIMESTAMP_LTZ
value in PyFlink, you get a pickling error:This is because there is no case to handle pickling
LocalZonedTimestampType
Instant
values in the pickler, which just defaults to trying to pickle theInstant
object which fails. This PR adds a clause to handle this (by creating aTimestamp
value from theInstant
, similar to howTimestamp
s are pickled), and adds a handler on the PyFlink side to convert this value to a datetime.Brief change log
LocalZonedTimestampType
types in the pickling/unpickling logic during collection.Verifying this change
I've added an extra case in the Table API environment type tests to include a test for
TIMESTAMP_LTZ
types insert/collection tests, which before this change fails with the above pickling error.Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation