[FLINK-38442][test] Make ProfilingServiceTest.testRollingDeletion more stable #27047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flinkbot run azure |
There was a problem hiding this comment.
Pull Request Overview
This PR improves the stability of ProfilingServiceTest.testRollingDeletion by ensuring unique prefixes per test method. The issue was that all tests used the same resource ID prefix, causing race conditions when tests run in parallel during ./mvnw clean install.
- Modified test methods to accept
TestInfoparameter for unique identification - Updated resource ID generation to include test method name as suffix
- Enhanced rolling deletion verification to use test-specific resource IDs
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@yuchen-ecnu , @Myasuka may I ask you to take a look since you were working on this in past |
github-actions
bot
added
the
community-reviewed
github-actions
bot
added
the
community-reviewed
github-actions
bot
added
the
community-reviewed
github-actions
bot
added
the
community-reviewed
github-actions
bot
added
the
community-reviewed
raminqaf
approved these changes
Oct 2, 2025
snuyanzin
commented
Oct 2, 2025
| profilingService.requestProfiling(RESOURCE_ID, duration, mode).get(); | ||
| profilingService | ||
| .requestProfiling( | ||
| RESOURCE_ID + "_" + testInfo.getTestMethod().get().getName(), |
There was a problem hiding this comment.
just use test name as part of prefix to make it unique per test and to avoid tests impacting each other while concurrent execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The PR make the test more stable by making prefix unique per test.
The problem with the test that all use same prefix and at some point it counts items in profiling list by prefix which is same for all in this test. The problem could be reproduced while running tests in parallel (usually happens while
./mvnw clean install)Brief change log
Make prefixes unique per test
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): ( no)Documentation