Skip to content

Conversation

guilbill
Copy link

Description

Add react-admin in poweredBy.md

Which issue(s) this PR fixes:

Fixes #

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. doc Documentation things labels Sep 29, 2025
1. <a href="https://www.jpl.nasa.gov" rel="nofollow">NASA JPL 美国国家航空航天局 喷气推进实验室</a>
1. <a href="https://www.purcotton.com/" rel="nofollow">Purcotton 深圳全棉时代科技有限公司</a>
1. <a href="https://www.360.cn/" rel="nofollow">360 奇虎</a>
1. <a href="https://marmelab.com/react-admin/AuthProviderList.html" rel="nofollow">React-admin</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what this page is supposed to mean. Why isn't it the homepage?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure what to link... React-admin is a frontend framework for building B2B applications with React. It works with data providers to plug the admin to an api, and auth providers to plug the admin to whatever can handle authentication. One of the Auth-providers is @arte/ra-apisix-oidc that allows you to use apisix authentication.

So as I found that linking to React-admin homepage would be confusing, I choosed to link to the documentation refering to the authProvider list, where you can see the Apisix one.

Is it clearer and does it seems relevant ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the relevance here. I'll wait for other maintainers' opinions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation things size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants