fix: control button missing type=button
#2760
Conversation
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @json-q, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a potential issue where control buttons, when inadvertently placed within an HTML form, could trigger an unwanted form submission. By explicitly setting the type attribute of these buttons to button, the change ensures they behave as intended, preventing unintended side effects and improving the robustness of the UI components.
Highlights
- HTML Button Type: Explicitly set the
typeattribute of controlbuttonelements tobuttonto prevent default form submission behavior when nested within a form. ButtonControlUpdate: ThecreateButtonmethod inbuttonControl.tsnow ensures that created buttons havetype="button".SwipeControl Update: The button within theSwipecontrol inswipe.tsis now explicitly assignedtype="button".ZoomControl Update: Buttons created by theZoomcontrol inzoom.tsare now correctly assignedtype="button".
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
| const link = DOM.create('button', className, container) as HTMLLinkElement; | ||
| link.type = 'button'; |
There was a problem hiding this comment.
这里存在一个类型问题。创建的元素是 <button>，因此应该转换为 HTMLButtonElement，而不是 HTMLLinkElement。HTMLLinkElement 是用于 <link> 标签的，其 type 属性的含义也不同。此外，变量名 link 具有误导性，建议修改为 button 以提高代码清晰度。
| const link = DOM.create('button', className, container) as HTMLLinkElement; | |
| link.type = 'button'; | |
| const link = DOM.create('button', className, container) as HTMLButtonElement; | |
| link.type = 'button'; |
| return DOM.create('button', `l7-button-control ${className}`) as HTMLElement; | ||
| const btn = DOM.create('button', `l7-button-control ${className}`) as HTMLButtonElement; | ||
| btn.type = 'button'; | ||
| return btn as HTMLElement; |
There was a problem hiding this comment.
这里的 as HTMLElement 类型断言是多余的。HTMLButtonElement 是 HTMLElement 的子类型，因此可以直接返回，无需强制类型转换。
| return btn as HTMLElement; | |
| return btn; |
[English Template / 英文模板]
🤔 这个变动的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
控件的 button 元素应该有
type=button，避免祖先元素存在 form 时触发 form 的默认行为📝 更新日志
☑️ 请求合并前的自查清单