Skip to content

Conversation

Samuelopez-ansys
Copy link
Member

Description

Variable class refactoring. It should improve the usage of Object oriented programming, mainly in Circuit designs.

Issue linked

Close #6710

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@Samuelopez-ansys Samuelopez-ansys requested a review from a team as a code owner October 8, 2025 10:09
@Samuelopez-ansys Samuelopez-ansys changed the title Fix/issue 6710 FIX: Improve Variable management in Circuit Oct 8, 2025
@github-actions github-actions bot added the bug Something isn't working label Oct 8, 2025
eblanco-ansys
eblanco-ansys previously approved these changes Oct 8, 2025
@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 68.52590% with 79 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.45%. Comparing base (bb3143b) to head (fbdf93f).
⚠️ Report is 1 commits behind head on main.

❌ Your patch check has failed because the patch coverage (68.52%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6742       +/-   ##
===========================================
- Coverage   83.27%   57.45%   -25.82%     
===========================================
  Files         246      246               
  Lines       77487    77551       +64     
===========================================
- Hits        64526    44558    -19968     
- Misses      12961    32993    +20032     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Variable Defenition Error in Pyaedt

3 participants