fix: tooltip with bounds top/left clip calculation #1916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sign of these values has been wrong for a while. If we consider the case where top is zero, the ownBounds.height is 100, and the offset is 50, then if the tooltip is placed up the final top will be `0 - 100 - 50` = -150, or 150px of clipping. However the current topPlacementClippedPx calculation is `100 - 0 - 50` = 50px of calculated clipping. This isn't correct. Flipping the sign gives us `100 - 0 + 50` -> 150px, the correct value. This seems unintuitive since now we are adding the offset in both the top and bottom clip calculation despite them being offset in different directions, but the key is that topPlacementClippedPx measures the magnitude of negative clipping while bottomPlacementClippedPx measures positive clipping. So we've got a double negative for the top and need to use addition in both cases.
crsschwalm
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
The sign of these values has been wrong for a while.
If we consider the case where top is zero, the ownBounds.height is 100, and the offset is 50, then if the tooltip is placed up the final top will be
0 - 100 - 50= -150, or 150px out of bounds -> 150px of clipping.However the current topPlacementClippedPx calculation is
100 - 0 - 50= 50px of calculated clipping. This isn't correct. Flipping the sign gives us100 - 0 + 50-> 150px, the correct value.This seems unintuitive since now we are adding the offset in both the top and bottom clip calculation despite them being offset in different directions, but the key is that topPlacementClippedPx measures the magnitude of negative clipping while bottomPlacementClippedPx measures positive clipping. So we've got a double negative for the top and need to use addition in both cases.