Skip to content

Conversation

urmahp
Copy link
Contributor

@urmahp urmahp commented Oct 10, 2025

When reconnecting to RTDE it requires you to set the input and output recipes again, this is now done properly.

When reconnecting to RTDE it requires you to set the input and output recipes again, this is now done properly.
@urmahp urmahp requested a review from a team October 10, 2025 04:39
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 40.58824% with 101 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.80%. Comparing base (d68f808) to head (d3c06eb).

Files with missing lines Patch % Lines
src/rtde/rtde_client.cpp 40.13% 78 Missing and 13 partials ⚠️
include/ur_client_library/comm/producer.h 30.00% 6 Missing and 1 partial ⚠️
include/ur_client_library/comm/stream.h 0.00% 2 Missing ⚠️
src/rtde/rtde_writer.cpp 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
- Coverage   77.89%   76.80%   -1.10%     
==========================================
  Files          92       92              
  Lines        4208     4286      +78     
  Branches      467      483      +16     
==========================================
+ Hits         3278     3292      +14     
- Misses        692      750      +58     
- Partials      238      244       +6     
Flag Coverage Δ
start_ursim 83.14% <ø> (+1.80%) ⬆️
ur20-latest 74.73% <37.50%> (-1.11%) ⬇️
ur5-3.14.3 75.13% <40.58%> (-1.18%) ⬇️
ur5e-10.7.0 70.47% <40.00%> (-1.08%) ⬇️
ur5e-5.9.4 75.21% <40.00%> (-1.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@urfeex urfeex added the bugfix label Oct 13, 2025
Also fixed  that we can destroy the rtdeClient while reconnecting
@urmahp urmahp requested a review from urfeex October 13, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants