feat(ui5-upload-collection): add noDataHeaderLevel property #12458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🧹 Preview deployment cleaned up: https://pr-12458--ui5-webcomponents.netlify.app |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new noDataHeaderLevel property to the UploadCollection component, allowing developers to customize the header level of the "No data" text from the default "H2" to any valid title level.
- Adds
noDataHeaderLevelproperty with TypeScript typing and JSDoc documentation - Updates the template to use the configurable header level instead of hard-coded "H2"
- Includes comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/fiori/src/UploadCollection.ts | Adds the noDataHeaderLevel property with proper typing and documentation |
| packages/fiori/src/UploadCollectionTemplate.tsx | Updates template to use the configurable header level property |
| packages/fiori/test/pages/UploadCollection.html | Adds test usage of the new property with "H3" value |
| packages/fiori/cypress/specs/UploadCollection.cy.tsx | Adds comprehensive test coverage for the new property functionality |
s-todorova
approved these changes
Oct 9, 2025
Stoev
reviewed
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10894