Skip to content

Restrict max sample rate #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Restrict max sample rate #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/AudioEngine.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,25 @@ const makeAudioContext = () => {
if (!AudioContext) {
throw new Error('Browser does not support AudioContext');
}
return new AudioContext();

const audioContextWithDefaultRate = new AudioContext();

// By default, browsers will use the sample rate of the output device. For people who have this
// configured very high, this can result in extreme increases in memory usage because we
// pre-decode all sounds into buffers at this sample rate.
if (audioContextWithDefaultRate.sampleRate > 48000) {
try {
return new AudioContext({
sampleRate: 48000
});
} catch (e) {
// If browser can't support our requested rate, we'll have to continue with whatever
// rate we got earlier, even if it's not going to be ideal.
return audioContextWithDefaultRate;
}
}

return audioContextWithDefaultRate;
};

/**
Expand Down