Added Implementation of Bit_Trie for finding max xor between two numbers in an array #13132
Conversation
for more information, see https://pre-commit.ci
…r/Python into sliding_window_xor
for more information, see https://pre-commit.ci
…r/Python into sliding_window_xor
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
the
require tests
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| def __init__(self) -> None: | ||
| self.root = TrieNode() | ||
|
|
||
| def insert(self, num: int) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file bit_manipulation/max_xor_bit_trie.py, please provide doctest for the function insert
| node.child[bit] = TrieNode() | ||
| node = node.child[bit] | ||
|
|
||
| def query_max_xor(self, num: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file bit_manipulation/max_xor_bit_trie.py, please provide doctest for the function query_max_xor
| node = node.child[bit] | ||
| return max_xor | ||
|
|
||
| def find_maximum_xor(self, nums: list[int]) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file bit_manipulation/max_xor_bit_trie.py, please provide doctest for the function find_maximum_xor
algorithms-keeper
bot
removed
the
require tests
for more information, see https://pre-commit.ci
…r/Python into max_xor_bit_trie_1
for more information, see https://pre-commit.ci
|
Hello i am facing issues in the pre-commit check ,can anyone help me |
algorithms-keeper
bot
added
tests are failing
Description of Change
This pull request adds a Python implementation of the Bitwise Trie (Binary Trie) to solve the Maximum XOR of Two Numbers in an Array problem.
The algorithm constructs a binary trie for all 32-bit integers in the input array and efficiently queries the maximum XOR achievable for each number. The implementation is self-contained and includes multiple test cases to ensure correctness.
Checklist
Notes:
list[int]) and 32-bit integers for consistency.