Add simple blockchain mining algorithm with PoW #13114
Conversation
algorithms-keeper
bot
added
require tests
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
blockchain/simple_blockchain.py
Outdated
| hash (str): SHA256 hash of the block's content. | ||
| """ | ||
|
|
||
| def __init__(self, index: int, data: str, previous_hash: str, difficulty: int = 2): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
| self.previous_hash = previous_hash | ||
| self.nonce, self.hash = self.mine_block(difficulty) | ||
|
|
||
| def compute_hash(self, nonce: int) -> str: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file blockchain/simple_blockchain.py, please provide doctest for the function compute_hash
blockchain/simple_blockchain.py
Outdated
| chain (List[Block]): List of blocks forming the chain. | ||
| """ | ||
|
|
||
| def __init__(self, difficulty: int = 2): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
algorithms-keeper
bot
added
awaiting reviews
LetitiaGilbert
force-pushed
the
add-blockchain-mining-algorithm
branch
from
bb3b23d to
c7f0210
Compare
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| self.previous_hash = previous_hash | ||
| self.nonce, self.hash = self.mine_block(difficulty) | ||
|
|
||
| def compute_hash(self, nonce: int) -> str: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file blockchain/simple_blockchain.py, please provide doctest for the function compute_hash
blockchain/simple_blockchain.py
Outdated
| chain (List[Block]): List of blocks forming the chain. | ||
| """ | ||
|
|
||
| def __init__(self, difficulty: int = 2): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
require tests
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
blockchain/simple_blockchain.py
Outdated
| chain (List[Block]): List of blocks forming the chain. | ||
| """ | ||
|
|
||
| def __init__(self, difficulty: int = 2): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
require type hints
Describe your change:
This PR adds a simple blockchain implementation with Proof-of-Work (PoW) to the blockchain folder.
Features:
File location: blockchain/simple_blockchain.py
Checklist: