Patch for memory usage in template_similarity
#4152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…erface into memory_template_similarity
for more information, see https://pre-commit.ci
…erface into memory_template_similarity
for more information, see https://pre-commit.ci
alejoe91
changed the title
template_similarity
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the way we are computing the similarity extension precomputes a large mask matrix of size n_templates x n_templates x n_channels. But it these numbers are large, this is saturating the memory for no reasons, because actually, we only need one row at a time while computing similarities. This is a patch for the situation and should solve #4150
For some unknow reason, I can not get numba use the python function get_mask_for_sparse_template(), thus there is some code duplication