feat: leptos dismissable-layer #571
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: work in progress. I've not started cleaning up the code yet. As such there's dependencies pulled in that are not used (becuase I used them, then did something else). This is also completely untested as of yet.
I started work on DismissableLayer. This is my first forray into leptos, so it's very possible I'm doing a lot of stupid things. Figured I'd throw out a draft PR since at this point it's compiling. I've not tested anything yet, nor started cleanup.
Also, there are a few utilities I've made (like the
ClientOnly) which I think might belong in some kind of utils crate. Let me know what you think (of if I should just eliminate it). Same with theDismissableLayerEventDetailtrait.