use j2se variable and collapse on split #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getJVMArgs() function has two problems: - It uses the J2SE pointer directly, rather than its abstraction, leading to null pointer accesses. - It splits on " " without collapsing consecutive occurances of the token, leading to invalid arguments being passed to the JVM (e.g. the main class is passed in as an empty string) when the xml has whitespace in the java-vm-args attribute. Fix these two problems by using the proper variable for accessing the JavaVMArgs, and split them in a fashion that skips consecutive whitespace. In a similar vein, also strip whitespace in the args prior to doing this work so that an entirely empty attribute does not lead to us unnecessarily adding arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getJVMArgs() function has two problems:
leading to null pointer accesses.
token, leading to invalid arguments being passed to the JVM (e.g. the
main class is passed in as an empty string) when the xml has
whitespace in the java-vm-args attribute.
Fix these two problems by using the proper variable for accessing the
JavaVMArgs, and split them in a fashion that skips consecutive
whitespace.
In a similar vein, also strip whitespace in the args prior to doing this
work so that an entirely empty attribute does not lead to us
unnecessarily adding arguments.