Refactor in preparation for supporting POI and ENTITIES MCA files #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates on this? |
…ut having to handle all the tags inbetween yourself.
…mca file did not already exist and it contained no chunks. Also noticed another old bug in MCAUtil#write and added a TODO to address it.
Changing from the dead repo jcenter to mavenCentral Setting 'version' to differentiate this branch.
…test resource mca files.
…test resource mca files.
… versions for 1.20.3 & 1.20.4
…hrough v1.17.* now complete.
…e/deserialize/manipulation
…lists so it is parseable by the SNBT parser - and it just looks better too.
…to write SNBT to a text file.
…nbt view of the chunk data it has been given, and adding the TESTDBG path to .gitignore
…ntPointXYZ to its API, enhanced iterator to support filtered iteration
…Bytes(byte[]) to auto-detect compression strategy based on magic-header values.
…This is useful for setting up optimized scenarios for the direct comparison of byte[]'s instead of having to first convert to tags.
…essionType param - they compute which CompressionType to use.
…NBT without full object overhead. Thi solution is solidly 5-6x faster than deserializing to Tag objects, sort and write to bin nbt
… BinaryNbtTagSorter
…h and improvements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Love your library! I hope you can incorporate this large refactor which expands the mca API to improve ease of use and is a prerequisite for adding support for the new(ish) POI and ENTITES mca files. Also as I've started looking into the chunk data changes for 1.18... they look to be heading toward somewhat extensive and I'm willing to take on making the changes needed to support 1.18, but I'll be building in that support on top of my fork.
Let me know if you want to chat more, etc. Please perform your own integration testing as well as my changes add some fail-fast check to keep consumers from shooting themselves in the foot.